Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4369 introduced
-webSocket
transport, which was at the time considered experimental and so the default remained-http
. Since then, as far as I know it has been stable (at least after #5455), so it seems appropriate to make it the default now rather than-http
which relies on a hack (FullDuplexHttpService
) to keep two HTTP connections open. Since both modes accept the same authentication option—namely, an API token—the change ought to be transparent for most users.Testing done
Ran with various transport options, or none, plus
-logger FINE
to confirm the mode being used.Proposed changelog entries
-webSocket
. You can specify-http
to continue to use the former default (for example because you are running Jenkins in a servlet container other than the recommended built-in Jetty, or because you are running an unusual reverse proxy which does not support WebSocket). You can also continue to specify-ssh
to use SSH transport (for example because you prefer to authenticate with a private key rather than an API token), or use a native SSH client.Proposed upgrade guidelines
If you use the Jenkins CLI but cannot make WebSocket connections to the Jenkins controller, you will now need to pass the
-http
or-ssh
option if you were not already doing so.Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).