Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computer links in some cases #7608

Merged
merged 3 commits into from Feb 9, 2023

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 26, 2023

#6907 computes computer urls based on privilege, which can cause inconsistent breadcrumb update as a result.

$jenkinsUrl/manage/computer/ is typically the URL you access when browsing Manage Jenkins > Configure Nodes and Clouds

vs.

$jenkinsUrl/computer/ which can be accessed by clicking on Build Executor Status

This changes links from /computer/ view to relative urls, so that navigation breadcrumb is preserved whether you come from the main screen or the manage screen.

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

  • Fix computer links navigation consistency.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

jenkinsci#6907 computes computer urls based on
privilege, which can cause inconsistent breadcrumb update as a result.

$jenkinsUrl/manage/computer/ is typically the URL you access when
browsing "Manage Jenkins > Configure Nodes and Clouds"

vs.

$jenkinsURl/computer/ which can be accessed by clicking on "Build
Executor Status"
@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Jan 26, 2023
@jenkinsci jenkinsci deleted a comment Jan 28, 2023
@NotMyFault NotMyFault added the web-ui The PR includes WebUI changes which may need special expertise label Jan 31, 2023
@NotMyFault NotMyFault requested a review from a team January 31, 2023 16:39
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 7, 2023
@NotMyFault NotMyFault merged commit 8b64efc into jenkinsci:master Feb 9, 2023
@timja
Copy link
Member

timja commented Mar 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
3 participants