[JENKINS-49138] Build Now to redirect to new build #7633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Feb 7, 2023
| setTimeout(function () { | ||
| new Ajax.Request(t.getHeader('Location') + 'api/json?tree=executable[url]', { | ||
| onSuccess: function (t2) { | ||
| if (t2.status === 200 && t2.responseJSON.executable != null && t2.responseJSON.executable.url != null) { |
20 tasks
jglick
commented
Mar 30, 2023
| @@ -30,7 +30,22 @@ THE SOFTWARE. | |||
| <l:task href="${url}/build?delay=0sec" icon="icon-clock icon-md" onclick="${it.parameterized?null:'return build_' + id + '(this)'}" permission="${it.BUILD}" post="${!it.parameterized}" title="${it.buildNowText}"/> | |||
| <script> | |||
| function build_${id}(a) { | |||
| new Ajax.Request(a.href); | |||
| new Ajax.Request(a.href, { | |||
github-actions
bot
added
the
unresolved-merge-conflict
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
Ideally would wait for #7635. |
14 tasks
|
This is now actionable again, back to my to-do list… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-49138. There are a lot of different UI gestures to trigger a build, and this just covers one of them so far, and perhaps not in the ideal way (needs UX design in some cases). Not sure if I have the appetite to continue, or if it makes sense to open for review even when incomplete.
Testing done
build-now.mp4
Proposed changelog entries
Maintainer checklist
Before the changes are marked as
ready-for-merge:upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).