Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch fixed for Jenkin Client Console output encoding(charset) issue #775

Closed
wants to merge 4 commits into from

Conversation

qxo
Copy link
Contributor

@qxo qxo commented May 7, 2013

No description provided.

@cloudbees-pull-request-builder

core » jenkins_main_trunk #865 SUCCESS
This pull request looks good

@qxo
Copy link
Contributor Author

qxo commented May 7, 2013

https://issues.jenkins-ci.org/browse/JENKINS-17881

This patch solve client-server encoding convert issue:

  1. server(master node) file.encoding=UTF-8 and jenkin client jvm file.encoding=GBK
  2. or jenkins slave file.encoding=GBK and jenkins client jvm file.encoding=UTF-8

test shell script: echo "测试"

1 similar comment
@qxo
Copy link
Contributor Author

qxo commented May 7, 2013

https://issues.jenkins-ci.org/browse/JENKINS-17881

This patch solve client-server encoding convert issue:

  1. server(master node) file.encoding=UTF-8 and jenkin client jvm file.encoding=GBK
  2. or jenkins slave file.encoding=GBK and jenkins client jvm file.encoding=UTF-8

test shell script: echo "测试"

@kutzi
Copy link
Member

kutzi commented May 7, 2013

Is it possible to write a unit test for the issue?

@qxo
Copy link
Contributor Author

qxo commented May 8, 2013

Yes

@qxo
Copy link
Contributor Author

qxo commented May 8, 2013

Where? for the unit test,Can you give a example?

2013/5/7 Christoph Kutzinski notifications@github.com

Is it possible to write a unit test for the issue?


Reply to this email directly or view it on GitHubhttps://github.com//pull/775#issuecomment-17538725
.

qxo added 2 commits May 8, 2013 05:38
fixed for build parameter value contain '='  will  ignore substring  aft...
@cloudbees-pull-request-builder

core » jenkins_main_trunk #868 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

core » jenkins_main_trunk #869 SUCCESS
This pull request looks good

@jglick
Copy link
Member

jglick commented May 17, 2013

Bits of the patch might be usable but I think this pull request is too garbled to ever be accepted.

@jglick jglick closed this May 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants