[FIXED JENKINS-4409] Use a fixed directory for TestPluginManager. #780
Conversation
…Jenkins for the test.
|
core » jenkins_main_trunk #877 UNSTABLE |
|
@cloudbees-pull-request-builder Hmm... A failure caused by this change? |
|
No. The failure seems caused for http://updates.jenkins-ci.org/ is out of service. |
|
Hmm...I seem not allowed to trigger a build... |
| @@ -123,7 +128,14 @@ public void stop() { | |||
|
|
|||
| static { | |||
| try { | |||
| INSTANCE = new TestPluginManager(); | |||
| File rootDir = new File("./target/plugin-manager-for-test").getAbsoluteFile(); | |||
There was a problem hiding this comment.
No good, this will behave differently depending on the CWD in effect when the test is run, which could be anything.
|
Using a fixed directory seems dangerous—it means that different parallel test runs could clobber one another, or tests might pick up obsolete plugin versions from an older test run, etc. I would rather try to diagnose and fix the failure to delete the JAR files. Typically this just means that someone is forgetting to close a |
|
@jglick OK. I'll try that. Thanks! |
TestPluginManager expands plugins to a temporary directory at the start of all tests. This temporary directory is deleted with a shutdown hook of JVM.
In Windows, for JVM holds the handle of jar files bundled with plugins, it always fails to delete the temporary directory where plugins expanded. That is, ${java.io.tmpdir}/hudson*tmp is left even after the test finishes. Every time a test runs, the size of the temporary directory grows up.
TestPluginManager seems not need to use a different directory every time. Using a fixed directory prevents the size of the temporary directory growing up.
JENKINS-4409