Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71115] Builds filter field doesn't use full width on sub 970px windows #7870

Merged
merged 1 commit into from May 1, 2023

Conversation

niralmaruda
Copy link
Contributor

@niralmaruda niralmaruda commented Apr 21, 2023

Removed max-width:420 from search-bar.scss which resolved the issue

  • After changes the Build filter field is flexible with relative to browser window size.
  • This pull request does not have any test because the changes was in scss file.
  • Kindly do let me know if I have missed anything by chance.

See JENKINS-71115.

Testing done

  • I have build and tested on my PC and it works as needed.
  • The Build filter filed cover size with respect to browser window.

Proposed changelog entries

  • Show full width filter field for builds on pages less than 970 pixels wide.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.

Desired reviewers

New to this community. Happy to connect with anyone to build long term friendship/mentorship.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Removed max-width field from search-bar.scss
@NotMyFault NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Apr 21, 2023
@NotMyFault NotMyFault requested a review from a team April 21, 2023 15:48
@NotMyFault NotMyFault added the web-ui The PR includes WebUI changes which may need special expertise label Apr 21, 2023
@daniel-beck
Copy link
Member

daniel-beck commented Apr 24, 2023

While this looks like a simple fix, I wonder whether this breaks something else. Originally added in #7074 #5842 so @janfaracik should be able to explain the purpose of the rule.

@janfaracik
Copy link
Contributor

If I remember correctly the max width was for the New node page -

Before
image

After
Screenshot 2023-04-29 at 12 07 04

I'm good either way with the size. Setting a more specific selector would have been a better move on my part in #5842.

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 29, 2023
@NotMyFault NotMyFault merged commit cde5a55 into jenkinsci:master May 1, 2023
14 checks passed
@niralmaruda niralmaruda deleted the Bug-fix--JENKINS-71115 branch May 1, 2023 16:14
NotMyFault pushed a commit to NotMyFault/jenkins that referenced this pull request May 15, 2023
…px windows (jenkinsci#7870)

Bug fix: JENKINS-71115

Removed max-width field from search-bar.scss

(cherry picked from commit cde5a55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
4 participants