Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71160] Fix "Tmp directories are hidden" alert icon #7891

Merged
merged 2 commits into from Apr 28, 2023

Conversation

flabrie
Copy link
Contributor

@flabrie flabrie commented Apr 27, 2023

JENKINS-71160: In the Workspace section of a Jenkins job, the icon URL reference of the "Tmp directories are hidden" alert is incorrect. It uses the old static 16x16 PING image instead of the SVG one.

See JENKINS-71160.

Testing done

Yes, same icon as Symlinks alert.

Proposed changelog entries

Fix the warning icon in the workspaces temporary directory message.

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

JENKINS-71160: In the Workspace section of a Jenkins job, the icon URL reference of the "Tmp directories are hidden" alert is incorrect. It uses the old static 16x16 PING image instead of the SVG one.
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite changed the title Fix JENKINS-71160: "Tmp directories are hidden" alert icon. [JENKINS-71160] Fix "Tmp directories are hidden" alert icon Apr 27, 2023
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Apr 27, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 27, 2023
@MarkEWaite MarkEWaite merged commit c8ded5d into jenkinsci:master Apr 28, 2023
16 checks passed
NotMyFault pushed a commit to NotMyFault/jenkins that referenced this pull request May 15, 2023
…i#7891)

* Fix JENKINS-71160: "Tmp directories are hidden" alert icon.

JENKINS-71160: In the Workspace section of a Jenkins job, the icon URL reference of the "Tmp directories are hidden" alert is incorrect. It uses the old static 16x16 PING image instead of the SVG one.

* Update other icon too

---------

Co-authored-by: Alexander Brandes <mc.cache@web.de>
(cherry picked from commit c8ded5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
3 participants