[FIXED JENKINS-17977] [FIXED JENKINS-18032] confirmPOST needs to pass crumb #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
core » jenkins_main_trunk #902 SUCCESS |
| @@ -45,6 +45,7 @@ THE SOFTWARE. | |||
| var form = document.createElement('form'); | |||
| form.setAttribute('method', post ? 'POST' : 'GET'); | |||
| form.setAttribute('action', href); | |||
| crumb.appendToForm(form); | |||
There was a problem hiding this comment.
Crumbs only apply to POST requests. So, try
if (post) {
crumb.appendToForm(form);
}
There was a problem hiding this comment.
Given that only GET and POST are supported it makes sense to do it that way. I'll change it.
|
There are probably some other spots where a POST request is sent from AJAX without including a crumb; search |
|
core » jenkins_main_trunk #933 UNSTABLE |
jglick
added a commit
that referenced
this pull request
Jun 19, 2013
Fixed confirmPOST JS utility not working with CSRF protection enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (at least) the following issues: