New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Guice 5.1.0 to 6.0.0 #7990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a changelog entry?
There we go. |
I've submitted a draft plugin bill of materials pull request to test this change. Should it also be run in the acceptance tests? |
ATH is green. |
jenkinsci/jenkins#7990 is the core pull request jenkinsci/bom#2070 is the plugin BOM PR.
I think that we should check it with a full run of the acceptance test harness. I've submitted jenkinsci/acceptance-test-harness#1176 as a draft pull request. My mistake. This was already tested successfully in ATH with jenkinsci/acceptance-test-harness#1173 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7477 seems to be holding up nicely.
Guice 6 smooths the way for Jakarta bindings, by keeping compatibility with javax.* and adding support for jakarta.* alongside, where Guice 7 ended support for javax.* bindings while supporting jakarta.* only.
Going from 5 to 6, over 5 to 7, is the safer approach because we can adapt jakarta when we're ready for it, without immediately cutting support for javax.
Additionally, it supports Java 21, which I'm really looking forward to :)
Closes #7987
Testing done
Compiling Jenkins against guice 6, while inspecting our methods bound properly.
Built a couple of pipeline and freestyle jobs and clicked around UI elements.
CI tests are passing too.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).