Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up DoubleLaunchChecker #8127

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 10, 2023

In #6743 I noticed various nonstandard idioms in this class, which are cleaned up here. Switches the tool to use the regular administrative monitor system.

Testing done

Added test coverage (using jenkinsci/jenkins-test-harness#610). Set a breakpoint to interactively check that the GUI is displayed like other monitors and can be dismissed.

Proposed changelog entries

  • Switch the double-launch checker to a regular administrative monitor.

Proposed upgrade guidelines

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options
Loading

test/pom.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 10, 2023
@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, but looks good.

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 12, 2023
@Vlatombe Vlatombe requested a review from a team June 12, 2023 15:53
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 13, 2023
@NotMyFault NotMyFault merged commit 9be693d into jenkinsci:master Jun 14, 2023
16 checks passed
@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 14, 2023
@jglick jglick deleted the DoubleLaunchChecker branch June 14, 2023 18:01
yaroslavafenkin pushed a commit to yaroslavafenkin/jenkins that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
4 participants