Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last build status to job page #8129

Merged
merged 8 commits into from Jul 17, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 10, 2023

Small PR to add the latest build status to the job page, making it consistent with the build pages/dashboard table. Drops the project prefix as its unnecessary. Also tightens up the appearance of the app bar/build caption combination, adjusting the size of the icon and text to make it more visually balanced.

image

Testing done

  • Build status is shown on the job page
  • Icon hides when there are no builds

Proposed changelog entries

  • Add last build status to job page

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 16, 2023
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK security wise

@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jun 27, 2023
@NotMyFault NotMyFault requested a review from a team June 30, 2023 14:51
@NotMyFault NotMyFault added the ath-successful This PR has successfully passed the full acceptance-test-harness suite label Jun 30, 2023
@janfaracik
Copy link
Contributor Author

@jenkinsci/sig-ux Could I get another look on this? Thanks! :)

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 14, 2023
@timja timja merged commit 357fde9 into jenkinsci:master Jul 17, 2023
17 checks passed
@timja timja deleted the revamp-build-caption branch July 17, 2023 07:51
@basil
Copy link
Member

basil commented Jul 28, 2023

@basil
Copy link
Member

basil commented Jul 28, 2023

@@ -48,7 +48,7 @@ THE SOFTWARE.
</div>
</div>

<t:buildCaption>${%Build} ${it.displayName} (<i:formatDate value="${it.timestamp.time}" type="both" dateStyle="medium" timeStyle="medium"/>)</t:buildCaption>
<t:buildCaption>${it.displayName} (<i:formatDate value="${it.timestamp.time}" type="both" dateStyle="medium" timeStyle="medium"/>)</t:buildCaption>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the build page the icon is now selectable but does nothing when clicked. Wouldn't it make sense to either remove the clickable (and selectable) state or navigate to the console log (as in the build history)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
6 participants