Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate findAncestor and findAncestorClass #8357

Merged
merged 3 commits into from Aug 15, 2023
Merged

Deprecate findAncestor and findAncestorClass #8357

merged 3 commits into from Aug 15, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Aug 10, 2023 •
edited by MarkEWaite

Couple of methods that just wrap the standard Javascript method element.closest(...). I've updated any usages of the method to use that instead.

Testing done

  • Had a quick scan and no console errors, Tools page 'Install automatically' optional blocks work as before

Proposed changelog entries

  • Deprecate findAncestor and findAncestorClass in hudson-behaviour.js.

Proposed upgrade guidelines

  • none

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Aug 10, 2023
@timja timja requested a review from a team August 10, 2023 14:15
@NotMyFault NotMyFault added developer Changes which impact plugin developers and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Aug 10, 2023
@timja
Copy link
Member

timja commented Aug 10, 2023

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 10, 2023
@NotMyFault NotMyFault requested a review from a team August 13, 2023 10:09
@timja timja merged commit dfb83f6 into jenkinsci:master Aug 15, 2023
18 checks passed
@timja timja deleted the deprecate-find-ancestor branch August 15, 2023 14:38
yaroslavafenkin pushed a commit to yaroslavafenkin/jenkins that referenced this pull request Sep 26, 2023
@janfaracik @yaroslavafenkin
Deprecate findAncestor and findAncestorClass (jenkinsci#8357)
797ba8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
3 participants
@janfaracik @timja @NotMyFault