Move Node monitoring option to app bar #8381

janfaracik · 2023-08-16T10:13:47Z

PR to move the 'Node monitoring' option to the Nodes' app bar from the side panel. Also slight tweaks to the page to remove the sidebar and adds a short description to explain what the pages does.

Before

After

Before

After

Testing done

Node monitoring works as before

Proposed changelog entries

Move Node monitoring option to app bar.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

daniel-beck · 2023-08-16T12:59:59Z

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

janfaracik · 2023-08-16T19:20:13Z

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

It'd align more so with https://weekly.ci.jenkins.io/design-library/Layouts/ 'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

Wadeck

Seems to be fine security wise

timja · 2023-08-18T14:02:33Z

Test failure needs looking at @janfaracik

timja · 2023-08-21T07:29:14Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

daniel-beck · 2023-08-22T12:38:58Z

'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

This rule basically invalidates every RootAction.

basil · 2023-08-24T02:35:21Z

This change broke some core tests due to a markup change, so how do we know that it won't break plugin tests if we haven't run PCT?

NotMyFault · 2023-08-29T10:28:41Z

This change broke some core tests due to a markup change, so how do we know that it won't break plugin tests if we haven't run PCT?

=> jenkinsci/bom#2432

basil

Great!

NotMyFault · 2023-09-05T10:23:25Z

'
/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

janfaracik added 6 commits August 13, 2023 20:20

Init

37b41e2

Update index.jelly

edfd4aa

Update index.jelly

7912867

Add description

e8d5985

Add description

09c712f

Merge branch 'master' into node-monitoring

e065518

timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Aug 16, 2023

timja approved these changes Aug 16, 2023

View reviewed changes

timja requested a review from a team August 16, 2023 10:55

timja added the needs-security-review Awaiting review by a security team member label Aug 16, 2023

timja requested a review from a team August 16, 2023 10:55

Wadeck reviewed Aug 18, 2023

View reviewed changes

Wadeck added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Aug 18, 2023

janfaracik added 2 commits August 18, 2023 19:22

Fix test

8d77afa

Update ComputerSetTest.java

0eae25a

NotMyFault mentioned this pull request Aug 20, 2023

Test core/8381 jenkinsci/acceptance-test-harness#1339

Closed

timja added the ath-successful This PR has successfully passed the full acceptance-test-harness suite label Aug 20, 2023

timja requested a review from NotMyFault August 20, 2023 15:10

NotMyFault approved these changes Aug 21, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 21, 2023

daniel-beck mentioned this pull request Aug 22, 2023

Sidepanel/app bar rule needs changes jenkinsci/design-library-plugin#272

Open

daniel-beck removed the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 24, 2023

Merge branch 'master' into node-monitoring

eae8140

NotMyFault mentioned this pull request Aug 28, 2023

Test core/8381 jenkinsci/bom#2432

Closed

basil approved these changes Aug 29, 2023

View reviewed changes

NotMyFault added the pct-successful This PR has successfully passed the full plugin-compatibility-test suite label Aug 29, 2023

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 5, 2023

MarkEWaite merged commit 30540d7 into jenkinsci:master Sep 9, 2023
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move Node monitoring option to app bar #8381

Move Node monitoring option to app bar #8381

janfaracik commented Aug 16, 2023 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

daniel-beck commented Aug 16, 2023

janfaracik commented Aug 16, 2023

Wadeck left a comment

timja commented Aug 18, 2023

timja commented Aug 21, 2023

daniel-beck commented Aug 22, 2023

basil commented Aug 24, 2023

NotMyFault commented Aug 29, 2023

basil left a comment

NotMyFault commented Sep 5, 2023

Move Node monitoring option to app bar #8381

Move Node monitoring option to app bar #8381

Conversation

janfaracik commented Aug 16, 2023 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

daniel-beck commented Aug 16, 2023

janfaracik commented Aug 16, 2023

Wadeck left a comment

Choose a reason for hiding this comment

timja commented Aug 18, 2023

timja commented Aug 21, 2023

daniel-beck commented Aug 22, 2023

basil commented Aug 24, 2023

NotMyFault commented Aug 29, 2023

basil left a comment

Choose a reason for hiding this comment

NotMyFault commented Sep 5, 2023

janfaracik commented Aug 16, 2023 •

edited by MarkEWaite

Loading