Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functionality from XStream2 where possible #8504

Merged
merged 1 commit into from Sep 20, 2023

Conversation

basil
Copy link
Member

@basil basil commented Sep 19, 2023

Minor code cleanup noticed while working on #8503:

  • InstallUtil was using raw XStream instead of the Jenkins-specific XStream2, which has some customizations. To be more consistent with other code, use XStream2.
  • RobustReflectionConverterTest and ClassFilterImplTest can't use XStream2 due to JEP 200 violations, but they still could use the Jenkins default driver, which is different from the XStream default. This makes these tests more consistent with all other XStream code in Jenkins which is using XStream2.getDefaultDriver().

Testing done

Ran all unit tests as well as ClassFilterImplTest.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the skip-changelog Should not be shown in the changelog label Sep 19, 2023
@NotMyFault NotMyFault requested a review from a team September 19, 2023 06:04
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 19, 2023
@NotMyFault NotMyFault merged commit 9edaffc into jenkinsci:master Sep 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
3 participants