Avoid saving disabled status when deleting a project #8528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performDelete
was callingmakeDisabled
to ensure that no new builds were scheduled for a project while it was being deleted. Unfortunately this API-level method was intended for general purposes, such as flipping the disabled flag on a valid project, and includesjenkins/core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
Lines 481 to 482 in da99f11
config.xml
to disk and fire a change, neither of which is necessary or desirable on a project which is about to be deleted.Testing done
None directly, but seems to solve a race condition seen in a CloudBees CI proprietary test.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).