Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-72028] replace deprecated URL() at core/src/main/java/hudson/ #8565

Merged
merged 23 commits into from Oct 11, 2023
Merged

[JENKINS-72028] replace deprecated URL() at core/src/main/java/hudson/ #8565

merged 23 commits into from Oct 11, 2023

Conversation

abhishekmaity
Copy link
Contributor

@abhishekmaity abhishekmaity commented Oct 4, 2023 •
edited by jtnord

Replace deprecated URL() with URI#.toURL() . Changes implemented for core/src/main/java/hudson/‎ files only.

See JENKINS-72028.

Testing done

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@abhishekmaity
Copy link
Contributor Author

/label java, hacktoberfest

@comment-ops-bot comment-ops-bot bot added the java Pull requests that update Java code label Oct 4, 2023
@comment-ops-bot
Copy link

I wasn't able to add the following labels: hacktoberfest

Check that the label exists and is spelt right then try again.

@abhishekmaity
Copy link
Contributor Author

/label hacktoberfest

@comment-ops-bot comment-ops-bot bot added the hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ label Oct 4, 2023
@abhishekmaity abhishekmaity changed the title [JENKINS-72028] replace deprecated URL() [JENKINS-72028] replace deprecated URL() at core/src/main/java/hudson/ Oct 5, 2023
@abhishekmaity
Copy link
Contributor Author

requesting @jtnord @timja @NotMyFault

jtnord
jtnord requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an occurence where the issue is silently swallowed, also please attempt to keep the diff to a minimum by not reformatting unchanged code.

core/src/main/java/hudson/tools/ZipExtractionInstaller.java Show resolved Hide resolved
core/src/main/java/hudson/FilePath.java Show resolved Hide resolved
core/src/main/java/hudson/TcpSlaveAgentListener.java Show resolved Hide resolved
core/src/main/java/hudson/cli/InstallPluginCommand.java Show resolved Hide resolved
core/src/main/java/hudson/model/UpdateCenter.java Show resolved Hide resolved
core/src/main/java/hudson/model/UpdateSite.java Outdated Show resolved Hide resolved
@NotMyFault NotMyFault added skip-changelog Should not be shown in the changelog hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR and removed hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ labels Oct 7, 2023
@abhishekmaity
Copy link
Contributor Author

@jtnord I have replaced with e.getCause(); at core/src/main/java/hudson/cli/InstallPluginCommand.java now but its getting SpotBugs warning. Can you help to fix it.

jtnord
jtnord requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have accidently deleted a critical file (FilePath) and is changing things outside core/src/main/java/hudson/` (in the PR title and summary). Looks like a bad merge.

core/src/main/java/hudson/FilePath.java Show resolved Hide resolved
core/src/main/java/hudson/cli/InstallPluginCommand.java Outdated Show resolved Hide resolved
@jtnord jtnord added hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ and removed hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR labels Oct 9, 2023
abhishekmaity and others added 2 commits October 9, 2023 23:09
@abhishekmaity
added back file
71824a1
@abhishekmaity @jtnord
Update core/src/main/java/hudson/cli/InstallPluginCommand.java
62633b0 
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
abhishekmaity and others added 2 commits October 10, 2023 19:14
@abhishekmaity @jtnord
Update core/src/main/java/hudson/TcpSlaveAgentListener.java
6c80670 
remove non required as per suggestion

Co-authored-by: James Nord <jtnord@users.noreply.github.com>
@abhishekmaity @jtnord
Update core/src/main/java/hudson/model/UpdateSite.java
de00dd3 
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
@jtnord jtnord added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Oct 10, 2023
jtnord
jtnord approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the build passes

@jtnord jtnord added the hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR label Oct 10, 2023
NotMyFault
NotMyFault approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
@NotMyFault NotMyFault merged commit dc190ba into jenkinsci:master Oct 11, 2023
17 checks passed
@abhishekmaity abhishekmaity deleted the url-depreciation-1 branch October 12, 2023 15:03
@basil
Copy link
Member

basil commented Oct 18, 2023

Causes JENKINS-72203. In the absence of a tested fix, I intend to revert this PR toward 2.429.

basil added a commit that referenced this pull request Oct 23, 2023
@basil
Revert "[JENKINS-72028] replace deprecated URL() at `core/src/main/…
a13cec7 
…java/hudson/` (#8565)"

This reverts commit dc190ba.
@basil basil mentioned this pull request Oct 23, 2023
Merged
basil added a commit that referenced this pull request Oct 23, 2023
@basil
[JENKINS-72203] Revert #8565 (#8637)
8c921e7 
This reverts commit dc190ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Regardless of the change status, this is a valid Hacktoberfest PR java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Milestone
No milestone
4 participants
@abhishekmaity @basil @jtnord @NotMyFault