Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72143] French translation #8578

Merged
merged 3 commits into from Oct 11, 2023

Conversation

jgreffe
Copy link
Contributor

@jgreffe jgreffe commented Oct 8, 2023

See JENKINS-72143.

Reported missing keys from hudson/Messages.properties to related Messages_fr.properties

Testing done

Proposed changelog entries

  • Translate hudson/Messages.properties into French.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@jgreffe jgreffe changed the title [JENKIINS-72143] French translation [JENKINS-72143] French translation Oct 9, 2023
@NotMyFault NotMyFault requested a review from a team October 9, 2023 10:48
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestions, good job!

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
Avertissement : ce plugin est compatible pour Jenkins {0} ou plus récent. \
Jenkins ne démarrera pas ce plugin s''il est installé.
PluginManager.depCompatWarning=\
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces plugins n''est pas compatible avec la version installée. \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces plugins n''est pas compatible avec la version installée. \
Avertissement : ce plugin nécessite des versions plus récentes de dépendances et au moins un de ces dépendances n''est pas compatible avec la version installée. \

The link "dependency" = "plugin" isn't obvious, this equivalent formulation seems better to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
@abhishekmaity
Copy link
Contributor

/label localization

Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion fixing a typo, LGTM otherwise!

core/src/main/resources/hudson/Messages_fr.properties Outdated Show resolved Hide resolved
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 10, 2023
@jgreffe
Copy link
Contributor Author

jgreffe commented Oct 10, 2023

/label hacktoberfest

@comment-ops-bot comment-ops-bot bot added the hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ label Oct 10, 2023
@NotMyFault NotMyFault merged commit 8ab2aca into jenkinsci:master Oct 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Related to Hacktoberfest. https://hacktoberfest.digitalocean.com/ localization ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
4 participants