Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72266] Upgrade Winstone from 6.14 to 6.16 (upgrade Jetty from 10.0.17 to 10.0.18 #8666

Merged
merged 1 commit into from Nov 4, 2023

Conversation

basil
Copy link
Member

@basil basil commented Oct 31, 2023

See JENKINS-72266.

Testing done

Built Jenkins core with these changes, started Winstone with HTTP 2 enabled and a self-signed TLS certificate, and verified that I could load the page in Firefox.

Proposed changelog entries

  • Add support for Unix Domain Sockets.
  • Upgrade Jetty from 10.0.17 to 10.0.18.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 31, 2023
@MarkEWaite
Copy link
Contributor

I'd like a review from at least one other core reviewer. If that review doesn't happen within 24 hours, I plan to merge this with a single review.

@jenkinsci/core-pr-reviewers could one of you review and approve this?

This PR is very nearly ready for merge. I will merge it after approximately 24 hours if there is no negative feedback.

@MarkEWaite MarkEWaite self-assigned this Nov 3, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 3, 2023
@NotMyFault NotMyFault merged commit d329577 into jenkinsci:master Nov 4, 2023
16 checks passed
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Nov 6, 2023
…m 10.0.17 to 10.0.18 (jenkinsci#8666)

[JENKINS-72266] Upgrade Winstone from 6.14 to 6.16 (upgrade Jetty from 10.0.17 to 10.0.18)

(cherry picked from commit d329577)
MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Nov 18, 2023
…m 10.0.17 to 10.0.18 (jenkinsci#8666)

[JENKINS-72266] Upgrade Winstone from 6.14 to 6.16 (upgrade Jetty from 10.0.17 to 10.0.18)

(cherry picked from commit d329577)
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Nov 26, 2023
…m 10.0.17 to 10.0.18 (jenkinsci#8666)

[JENKINS-72266] Upgrade Winstone from 6.14 to 6.16 (upgrade Jetty from 10.0.17 to 10.0.18)

(cherry picked from commit d329577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
4 participants