Added validation of FIPS password length #8694

Santhosh-CloudB · 2023-11-15T13:06:03Z

Testing done

FIPS Enabled Jenkins requires password to be 112 bits(14 chars) minimum. While creating a User, when the password is short, it was showing error in console and navigating to error page. Now a validation has been added to check the password length.

The error couldnt be caught since its unchecked exception and its been caused in the line of code where framework's encode method is called.this doesnt allow adding a new exception apart from the one defined in the interface.

Testing has been done in FIPS enabled Docker container.

Proposed changelog entries

Fips mode now requires a minimum of 14 characters for a password.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

welcome · 2023-11-15T13:06:07Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

core/src/main/resources/hudson/security/Messages.properties

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

Santhosh-CloudB · 2023-11-16T07:09:04Z

Issue created in Jenkins.io - https://issues.jenkins.io/browse/JENKINS-72332

timja · 2023-11-16T08:13:53Z

Please restore the pull request template https://github.com/jenkinsci/jenkins/blob/master/.github/PULL_REQUEST_TEMPLATE.md

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java

olamy

LGTM
But @Santhosh-CloudB you need to restore the template to have proper release notes, link to Jira etc..
Thanks

Santhosh-CloudB · 2023-11-21T07:19:45Z

Please restore the pull request template https://github.com/jenkinsci/jenkins/blob/master/.github/PULL_REQUEST_TEMPLATE.md

done

Santhosh-CloudB · 2023-11-21T07:37:40Z

done

olamy · 2023-11-23T10:20:31Z

@timja @daniel-beck, this looks to be good to merge now. Or something else you want to be changed?
Thanks

timja · 2023-11-23T15:53:43Z

The changelog template is broken please just copy and paste the whole template back in as text and edit it appropriately

olamy · 2023-11-23T22:14:45Z

The changelog template is broken please just copy and paste the whole template back in as text and edit it appropriately

@timja should be better now.

@Santhosh-CloudB I fixed the description with the changelog template

timja

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

Santhosh-CloudB · 2023-11-27T09:56:16Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja - Looks its not merged yet. can you pls merge it?

welcome · 2023-11-27T10:09:18Z

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.

added validation of FIPS password length

b7c61de

daniel-beck reviewed Nov 15, 2023

View reviewed changes

core/src/main/resources/hudson/security/Messages.properties Outdated Show resolved Hide resolved

Update core/src/main/resources/hudson/security/Messages.properties

4af17f3

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Nov 16, 2023

jwojciebee reviewed Nov 16, 2023

View reviewed changes

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java Outdated Show resolved Hide resolved

olamy added the fips label Nov 17, 2023

olamy approved these changes Nov 17, 2023

View reviewed changes

Created Constant for Password Length

60730e8

olamy requested review from jwojciebee and daniel-beck November 23, 2023 10:19

timja approved these changes Nov 23, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 23, 2023

timja merged commit f9f542b into jenkinsci:master Nov 27, 2023
17 checks passed

timja changed the title ~~added validation of FIPS password length~~ Added validation of FIPS password length Nov 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added validation of FIPS password length #8694

Added validation of FIPS password length #8694

Santhosh-CloudB commented Nov 15, 2023 •

edited by timja

Submitter checklist

Maintainer checklist

welcome bot commented Nov 15, 2023

Santhosh-CloudB commented Nov 16, 2023

timja commented Nov 16, 2023

olamy left a comment •

edited

Santhosh-CloudB commented Nov 21, 2023

Santhosh-CloudB commented Nov 21, 2023

olamy commented Nov 23, 2023

timja commented Nov 23, 2023

olamy commented Nov 23, 2023

timja left a comment

Santhosh-CloudB commented Nov 27, 2023

welcome bot commented Nov 27, 2023

Added validation of FIPS password length #8694

Added validation of FIPS password length #8694

Conversation

Santhosh-CloudB commented Nov 15, 2023 • edited by timja

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

welcome bot commented Nov 15, 2023

Santhosh-CloudB commented Nov 16, 2023

timja commented Nov 16, 2023

olamy left a comment • edited

Choose a reason for hiding this comment

Santhosh-CloudB commented Nov 21, 2023

Santhosh-CloudB commented Nov 21, 2023

olamy commented Nov 23, 2023

timja commented Nov 23, 2023

olamy commented Nov 23, 2023

timja left a comment

Choose a reason for hiding this comment

Santhosh-CloudB commented Nov 27, 2023

welcome bot commented Nov 27, 2023

Santhosh-CloudB commented Nov 15, 2023 •

edited by timja

olamy left a comment •

edited