Print deprecation warning when using -jnlpUrl
#8773
Merged
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to the latest release of Remoting, which prints this warning on the client side, and also add a similar warning on the server side as well to maximize the chances that the warning is actually seen by an administrator.
Testing done
Connected with
-jnlpUrl
and verified that the warning was printed on both the server and client side. Connected with-url
and-name
and verified that the warning was no longer printed on either the server or client side.Proposed changelog entries
-jnlpUrl ${JENKINS_URL}/computer/${AGENT_NAME}/jenkins-agent.jnlp
argument to the agent JAR has been deprecated; use-url ${JENKINS_URL}
and-name ${AGENT_NAME}
instead, potentially also passing in-webSocket
,-tunnel
, and/or work directory options as needed.Proposed upgrade guidelines
-jnlpUrl ${JENKINS_URL}/computer/${AGENT_NAME}/jenkins-agent.jnlp
argument to the agent JAR has been deprecated; use-url ${JENKINS_URL}
and-name ${AGENT_NAME}
instead, potentially also passing in-webSocket
,-tunnel
, and/or work directory options as needed. Official Docker images already use the new calling convention.Submitter checklist
@Restricted
or have@since TODO
Javadocs, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
, if applicable.eval
to ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).