Update the appearance of the stop button #8780

janfaracik · 2023-12-13T22:48:13Z

Small MR to update the appearance of the stop button component.

Before

After

Testing done

Component works as before, doesn't cause layout shifts

Proposed changelog entries

Update the appearance of the stop button.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

uhafner

UI looks good, Thanks!

One localization is broken now.

uhafner · 2023-12-14T07:23:25Z

core/src/main/resources/lib/hudson/executors.jelly

@@ -126,7 +126,7 @@ THE SOFTWARE.
                </st:include>
                <td class="pane" align="center" valign="middle">
                  <j:if test="${h.hasPermission(exeparent,exeparent.READ) and e.hasStopPermission()}">
-                    <l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%terminate this build}"  />
+                    <l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%Cancel}"  />


This will break the i18n, it would be better to use Cancel in the properties as {en} translation. Or rename all translations.

timja · 2023-12-15T16:36:02Z

Tests failing

CI build is too unreliable and I just want an incrementals...

This reverts commit 28df839.

yaroslavafenkin

Looks OK security wise.

Is it just me or alignment is off? Nor aligned with the progress bar, neither with #1.

daniel-beck · 2023-12-19T12:21:13Z

alignment is off

Not newly introduced per screenshots in PR comment.

timja · 2023-12-19T13:10:24Z

alignment is off

Not newly introduced per screenshots in PR comment.

similar-ish things noticed here:
#8761 (review)

a few things looking a bit funny but they were already in that state.

timja · 2023-12-19T13:10:30Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

DuMaM · 2023-12-29T00:19:39Z

Thanks :D I was waiting so long for this change.

janfaracik added 4 commits December 13, 2023 22:28

Init

1384091

Fixes

cd89aea

Update executors.jelly

91751cf

Update _buttons.scss

a112bd9

uhafner suggested changes Dec 14, 2023

View reviewed changes

janfaracik added 2 commits December 14, 2023 16:04

Fix i18n

157ba0b

Tidy up

edce488

uhafner approved these changes Dec 14, 2023

View reviewed changes

NotMyFault requested review from a team December 14, 2023 20:34

janfaracik added 2 commits December 16, 2023 09:36

Fix test

03aaafb

Merge branch 'master' into stop-button

9cee6c0

timja removed the needs-test-fix One or more test case(s) need to be updated label Dec 16, 2023

timja added 2 commits December 17, 2023 08:18

Temporary fast build

28df839

CI build is too unreliable and I just want an incrementals...

Revert "Temporary fast build"

5d9966f

This reverts commit 28df839.

timja mentioned this pull request Dec 17, 2023

test stop button jenkinsci/acceptance-test-harness#1447

Closed

timja added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite labels Dec 17, 2023

timja approved these changes Dec 17, 2023

View reviewed changes

Merge branch 'master' into stop-button

8d8630a

yaroslavafenkin reviewed Dec 19, 2023

View reviewed changes

yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Dec 19, 2023

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 19, 2023

NotMyFault merged commit 01c42a3 into jenkinsci:master Dec 20, 2023
17 checks passed

timja deleted the stop-button branch December 20, 2023 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the appearance of the stop button #8780

Update the appearance of the stop button #8780

janfaracik commented Dec 13, 2023 •

edited by MarkEWaite

Submitter checklist

Maintainer checklist

uhafner left a comment

uhafner Dec 14, 2023

timja commented Dec 15, 2023

yaroslavafenkin left a comment

daniel-beck commented Dec 19, 2023

timja commented Dec 19, 2023

timja commented Dec 19, 2023

DuMaM commented Dec 29, 2023

Update the appearance of the stop button #8780

Update the appearance of the stop button #8780

Conversation

janfaracik commented Dec 13, 2023 • edited by MarkEWaite

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

uhafner left a comment

Choose a reason for hiding this comment

uhafner Dec 14, 2023

Choose a reason for hiding this comment

timja commented Dec 15, 2023

yaroslavafenkin left a comment

Choose a reason for hiding this comment

daniel-beck commented Dec 19, 2023

timja commented Dec 19, 2023

timja commented Dec 19, 2023

DuMaM commented Dec 29, 2023

janfaracik commented Dec 13, 2023 •

edited by MarkEWaite