[FIXED JENKINS-19017] FileParameter - Handle non-null file parameters as different values #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves https://issues.jenkins-ci.org/browse/JENKINS-19017 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
|
Second commit corrects formatting of the legacy code section. Use synopsys-arc-oss@42f0aec to review functionality changes |
Previous fix invokes ProcessKiller only for top-level process. Built-in killRecursive() of WinProcess has been replaced by manual implementation from UnixProcess Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
|
core » jenkins_main_trunk #1212 FAILURE |
|
Sorry, I've committed wrong changes to the my local master branch instead of unit tests. |
|
Is there a reason you did not submit this again? |
|
@daniel-beck I'll re-submit the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: FileParameterValue::equals()
According to function docs, "In practice this will always be false, since location should be unique". However, in practice of queued builds location is relative path to file in workspace (which is specified in parameter configs), so that function returns true => Jenkins merges builds even if theirs file parameters are different.
It is not possible to use anything instead of bit-wise file comparison, because different files can be uploaded from same place during manual build submission. It can require much time in long queues...
I propose to consider files as different if they are specified in the build parameters.
PR resolves https://issues.jenkins-ci.org/browse/JENKINS-19017
Signed-off-by: Oleg Nenashev nenashev@synopsys.com