Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrestrict FilePath.isDescendant #8913

Merged
merged 2 commits into from Feb 2, 2024
Merged

Unrestrict FilePath.isDescendant #8913

merged 2 commits into from Feb 2, 2024

Conversation

rsandell
Copy link
Member

I needed this and noticed that it was still restricted.

Proposed changelog entries

  • Developer: Unrestricted FilePath.isDescendant

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@rsandell
Unrestrict FilePath.isDescendant
a9128eb 
I needed this and noticed that it was still restricted.
@rsandell rsandell requested a review from a team January 29, 2024 16:34
@NotMyFault
Fix spotless
99ad647 
Signed-off-by: Alexander Brandes <mc.cache@web.de>
@NotMyFault NotMyFault added the developer Changes which impact plugin developers label Jan 29, 2024
@rsandell
Copy link
Member Author

I see a couple of other methods being restricted, but not as clear indication to why as my method is. I feel they should be unrestricted as well, but I don't know the contexts of those methods to just go and do it.

@Vlatombe
Copy link
Member

Vlatombe commented Feb 1, 2024 •
edited

Introduced via security fix, and only used in c3351d2#diff-c0b1fd2e05260aae6e5c50402e5cdc0263d33c254912a4694521fc1f53313537R165

I don't have a fundamental issue with unrestricting it but do you foresee any usage for it in a plugin?
cc @Wadeck

Wadeck
Wadeck approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup task that we forgot after the release :)
(nowadays we have a todo item for after the release to reduce such situation to happen again)

@timja
Copy link
Member

timja commented Feb 1, 2024

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 1, 2024
@rsandell rsandell mentioned this pull request Feb 1, 2024
Merged
@NotMyFault NotMyFault merged commit 3e6dc60 into master Feb 2, 2024
18 checks passed
@NotMyFault NotMyFault deleted the rsandell-patch-1 branch February 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wadeck Wadeck Wadeck approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Milestone
No milestone
5 participants
@rsandell @Vlatombe @timja @Wadeck @NotMyFault