Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractPasswordBasedSecurityRealm.authenticateByPassword #8921

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 30, 2024

CloudBees CI includes a single sign-on system from a controller to an “operations center”. For the most part this just involves the usual SSO redirect dance. However there is also an implementation of createSecurityComponents allowing password authentication in case someone wants to use the REST or CLI with a password rather than an API token. While this is generally a bad idea, it would be supported without SSO so we needed some way to check the password on the operations center side. Due to the protected access here that was not possible without an extra API.

Testing done

Covered by a functional test in CloudBees CI. Not much to test here.

Proposed changelog entries

  • N/A, beta anyway

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@jglick jglick requested a review from Vlatombe January 30, 2024 23:48
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 1, 2024
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Feb 1, 2024
@NotMyFault NotMyFault merged commit 81679b4 into jenkinsci:master Feb 2, 2024
17 checks passed
@jglick jglick deleted the authenticateByPassword branch February 2, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
4 participants