Jenkins 19082

[arangamani]

This fixes the includeRegex parameter in ListView. There was a bug introduced in 1.526 where whatever the regex is given in the configuration is replaced by "on" as a wrong Stapler request parameter was used to compile the regex pattern.

It fixes: https://issues.jenkins-ci.org/browse/JENKINS-19082

[olivergondza]

Hi, thanks for contributing.

The commit that introduced the regression was already released. It introduced a new public API member ListView.setIncludeRegex(String) and the fix you propose removes it. I guess you can safely add

public void setIncludeRegex(String includeRegex) {
    setIncludeRegex(includeRegex, includeRegex);
}

to retain compatibility.

Please, try to avoid unnecessary backspace changes and include issue references to commit messages as suggested in https://wiki.jenkins-ci.org/display/JENKINS/contributing#contributing-CommitMessages.

[arangamani]

Oliver,

Sure. I can add that method to be backward compatible but that will still not work though.

In the coding style of any programming languages that I've used, I learned to strip trailing white spaces. Since I have a setting in my editor to remove that automatically, it stripped them off. I know it is hard to review because of so many changes. I will put those trailing white spaces back! I've already edited the commit messages to match the style and follow the same standard in the future.

Thanks for the review.

[Vlatombe]

This method is not meant to know it is called from a form submission, the signature change is unnecessary.

[Vlatombe]

Good catch about the parameter names, I've provided some feedback to your pull request.

[jglick]

I have a setting in my editor to remove that automatically

Good editors can be configured to only strip whitespace from lines you were already editing.

[Vlatombe]

I think this can be closed as I submitted #905 which has already been merged and is fixing the issue.