Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving a comment I made a decade ago (!) in b55c157: if a non-Pipeline build is interrupted by a controller restart,
ABORTED
status (used for all sorts of sudden interruptions unrelated to the logical build steps) is more natural thanFAILURE
(a problem in a specific step preventing the build from proceeding). This is also more consistent with Pipeline builds, ornode
blocks, that fail to resume for various reasons when normally they could.Testing done
None; apparently this does not have test coverage? Could add some if it seems valuable.
Proposed changelog entries
Before the changes are marked as
ready-for-merge
:Maintainer checklist
upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).