Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop shipping commons-lang3 #8997

Merged
merged 1 commit into from Mar 1, 2024
Merged

Stop shipping commons-lang3 #8997

merged 1 commit into from Mar 1, 2024

Conversation

basil
Copy link
Member

@basil basil commented Feb 27, 2024

#8971 inadvertently began bundling commons-lang3 in the WAR, something we do not want to do because we do not want to increase core's API surface area. Instead we prefer to rely on a library plugin to deliver this to consumers in the Jenkins plugin ecosystem. This library is only used in org.apache.commons.compress.harmony.unpack200.Pack200UnpackerAdapter, which we don't use anyway, so we can simply exclude commons-lang3 without any negative effects. See also apache/commons-compress#489.

Testing done

Built Jenkins and verified the WAR no longer contains commons-lang3.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@basil basil added the skip-changelog Should not be shown in the changelog label Feb 27, 2024
This was referenced Feb 27, 2024
Merged
Closed
Closed
@NotMyFault NotMyFault requested a review from a team February 28, 2024 21:20
timja
timja approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 28, 2024
@NotMyFault NotMyFault merged commit db29f34 into jenkinsci:master Mar 1, 2024
17 checks passed
@basil basil deleted the lang3 branch March 4, 2024 19:53
@basil
Copy link
Member Author

basil commented Mar 4, 2024

COMPRESS-669 FTR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

@StefanSpieker StefanSpieker StefanSpieker approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
4 participants
@basil @NotMyFault @timja @StefanSpieker