[JENKINS-72998] call refresh on the Extension providers again #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case the ExtensionFinder is itself extensible we refresh it again to catch extensions that would be discovered by a newly installed extension. This seems a little overzerlous, as there is only the variant plugin that I know of, however calling `Jenkins.get().refreshExtensions() from any point in the `variant` plugin would seem to be a little bit dangerous as it would call back into a place where the reactor is already calling back from.
jglick
approved these changes
Apr 11, 2024
It's possible (it's just code!) but it is a really bad ux as [ platform-plugins and this would mean the default install flow would now require a restart, due to its dependency on ssh-credentials which optionally depends on trilead-api via OptionalExtension and ssh-shaves has a direct dependency on trilead-api
|
jtnord
changed the title
|
https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-1528/2/testReport/ shows 2 consistend new failures with this PR.. investigating. |
fails when run with latest master also so is unrelated to this change |
timja
approved these changes
Apr 12, 2024
comment-ops-bot
bot
added
the
ready-for-merge
NotMyFault
pushed a commit
to NotMyFault/jenkins
that referenced
this pull request
Apr 28, 2024
…sci#9157) [JENKINS-58302] call refresh on the Extension providers again In the case the ExtensionFinder is itself extensible we refresh it again to catch extensions that would be discovered by a newly installed extension. This seems a little overzerlous, as there is only the variant plugin that I know of, however calling `Jenkins.get().refreshExtensions() from any point in the `variant` plugin would seem to be a little bit dangerous as it would call back into a place where the reactor is already calling back from. (cherry picked from commit cb89cad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the
ExtensionFinderis itself extensible we refresh it again to catch extensions that would be discovered by a newly installed extension.This seems a little overzerlous, as there is only the variant plugin that I know of, however calling
Jenkins.get().refreshExtensions()from any point in thevariantplugin would seem to be a little bit dangerous as it would call back into a place where the reactor is already calling back from.See JENKINS-72998.
Testing done
started a clean jenkins without any plugins
installed ssh-slaves, ssh-credentails & credentials
Attempted to create a new SSH based slave with a credential
validated credentials are not listed before this change and they are after
see jenkinsci/acceptance-test-harness#1526
incremental build tested with ATH
Proposed changelog entries
variantplugin is installed at the same time as a plugin that has anOptionalExtensionthen these extensions would not be correctly discovered, until the next scan for newExtensions.Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).