Feature/add null text alt #9296

JanhviHarwani · 2024-05-21T19:26:21Z

See JENKINS-62424.

Testing done

Proposed changelog entries

JENKINS-62424, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.

The Jira issue, if it exists, is well-described.
Options
Successfully updated the issue's project

There was an error updating the issue's project
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see [examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)). Fill in the **Proposed upgrade guidelines** section only if there are breaking changes or changes that may require extra steps from users during upgrade.

The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
Options
Successfully updated the issue's project

There was an error updating the issue's project
There is automated testing or an explanation as to why this change has no tests.

There is automated testing or an explanation as to why this change has no tests.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New public classes, fields, and methods are annotated with `@Restricted` or have `@since TODO` Javadocs, as appropriate.

New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New deprecations are annotated with `@Deprecated(since = "TODO")` or `@Deprecated(forRemoval = true, since = "TODO")`, if applicable.

New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
Options
Successfully updated the issue's project

There was an error updating the issue's project
New or substantially changed JavaScript is not defined inline and does not call `eval` to ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).

New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
Options
Successfully updated the issue's project

There was an error updating the issue's project
For dependency updates, there are links to external changelogs and, if possible, full differentials.

For dependency updates, there are links to external changelogs and, if possible, full differentials.
Options
Successfully updated the issue's project

There was an error updating the issue's project
For new APIs and extension points, there is a link to at least one consumer.

For new APIs and extension points, there is a link to at least one consumer.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.

Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Changelog entries in the pull request title and/or **Proposed changelog entries** are accurate, human-readable, and in the imperative mood.

Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Options
Successfully updated the issue's project

There was an error updating the issue's project
Proper changelog labels are set so that the changelog can be generated automatically.

Proper changelog labels are set so that the changelog can be generated automatically.
Options
Successfully updated the issue's project

There was an error updating the issue's project
If the change needs additional upgrade steps from users, the `upgrade-guide-needed` label is set and there is a **Proposed upgrade guidelines** section in the pull request title (see [example](https://github.com/jenkinsci/jenkins/pull/4387)).

If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
Options
Successfully updated the issue's project

There was an error updating the issue's project
If it would make sense to backport the change to LTS, a Jira issue must exist, be a _Bug_ or _Improvement_, and be labeled as `lts-candidate` to be considered (see [query](https://issues.jenkins.io/issues/?filter=12146)).

If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

Open Issue: https://issues.jenkins.io/plugins/servlet/mobile#issue/JENKINS-62424
resolved: added null text to alt attribute to img tags wherever necessary

merging current changes

welcome · 2024-05-21T19:26:25Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

MarkEWaite · 2024-05-21T20:15:46Z

@JanhviHarwani I'm leaving this pull request open because it might address the Jira issue that is mentioned. It does not complete the pull request template. It does not provide a description of the testing that was performed to assure that the pull request works as expected. It does not include a usable changelog entry.

Could you complete those items on the pull request?

We're happy to have more contributors to Jenkins, but we need those new contributors to follow the processes that we've outlined so that we don't waste the time of maintainers as they process pull requests that do not provide the required information.

MarkEWaite

Thanks for the proposals. I've suggested different text based on the context of the images.

MarkEWaite · 2024-05-21T20:16:47Z

.github/config.yml

@@ -20,6 +20,6 @@ firstPRMergeComment: >

  <a href="https://www.jenkins.io/participate/" target="_blank">
   <picture>
-     <img width="600" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
+     <img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">


Jenkins is an English language proper noun. It needs to be capitalized.

Suggested change

<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

<img width="600" alt="Jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

~~Needs to be localizable.~~

Suggested change

<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

<img width="600" alt="${%Jenkins welcome page}" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

Additionally I am not sure welcome page adequately describes what this is.

I don't think that we can localize the text in pages that are generated by GitHub Actions.

Good point, I managed to comment this on the only file it doesn't apply to 😅 (all your suggestions are not localizable).

MarkEWaite · 2024-05-21T20:18:40Z

core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly

@@ -61,7 +61,7 @@ THE SOFTWARE.
          </j:otherwise>
        </j:choose>
      </div>
-      <img src="graph?type=${type}&amp;width=500&amp;height=300" />
+      <img src="graph?type=${type}&amp;width=500&amp;height=300" alt="null" />


Since this is the memory usage monitor graph, I think that the alt text should say that. The word "null" won't help a disabled user understand what is being shown in the image.

Suggested change

<img src="graph?type=${type}&width=500&height=300" alt="null" />

<img src="graph?type=${type}&width=500&height=300" alt="memory usage monitor graph" />

MarkEWaite · 2024-05-21T20:19:36Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

@@ -50,13 +50,13 @@ THE SOFTWARE.
            ${%No files in directory}
           <j:if test="${showSymlinkWarning}">
             <p>
-                <img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+                <img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>


Since this is showing a symlink warning, I think that the alt text should mention symlink alert

Suggested change

<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>

<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink alert"/>

MarkEWaite · 2024-05-21T20:19:54Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

               ${%Symlinks are hidden}
             </p>
            </j:if>
           <j:if test="${showTmpDirWarning}">
             <p>
-               <img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+               <img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>


Suggested change

<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>

<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="temporary directory warning"/>

MarkEWaite · 2024-05-21T20:22:19Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

@@ -124,13 +124,13 @@ THE SOFTWARE.
           </table>
           <j:if test="${showSymlinkWarning}">
             <p>
-                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="warning image"/>


I don't think that we need to use the word "image" in alt text, since the disabled user receives hints that they are seeing the alt text for an image. A Harvard accessibility page advises against including the "image of" or "image" in the alt text

Suggested change

<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="warning image"/>

<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink warning"/>

MarkEWaite · 2024-05-21T20:23:50Z

core/src/main/resources/jenkins/model/Jenkins/_404.jelly

@@ -34,7 +34,7 @@ THE SOFTWARE.
        <l:header />
        <l:main-panel>
            <h1 style="text-align: center">
-                <img src="${imagesURL}/rage.svg" height="179" width="154"/>
+                <img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/>


This is the "page not found" image.

Suggested change

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/>

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="Page not found"/>

MarkEWaite · 2024-05-21T20:24:10Z

core/src/main/resources/jenkins/model/Jenkins/_404_simple.jelly

@@ -48,7 +48,7 @@ THE SOFTWARE.
            </head>
            <body style="font-family: system-ui, sans-serif">
                <h1 style="text-align: center">
-                    <img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle"/>
+                    <img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle" alt="null"/>


Suggested change

<img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle" alt="null"/>

<img src="${imagesURL}/rage.svg" height="179" width="154" style="vertical-align: middle" alt="page not found"/>

MarkEWaite · 2024-05-21T20:24:32Z

core/src/main/resources/jenkins/model/Jenkins/oops.jelly

@@ -32,7 +32,7 @@ THE SOFTWARE.
    <l:header />
    <l:main-panel>
        <h1 style="text-align: center">
-          <img src="${imagesURL}/rage.svg" height="179" width="154"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
+          <img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>


Suggested change

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <st:nbsp/>${%Oops!}

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="Oops"/> <st:nbsp/>${%Oops!}

Decorative only. Also, null isn't intended as a literal value, but to represent the explicitly specified empty value (alt="").

Suggested change

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <st:nbsp/>${%Oops!}

<img src="${imagesURL}/rage.svg" height="179" width="154" alt=""/> <st:nbsp/>${%Oops!}

MarkEWaite · 2024-05-21T20:25:26Z

core/src/main/resources/lib/hudson/executors.jelly

@@ -41,7 +41,7 @@ THE SOFTWARE.
        <j:if test="${c.offline}">
          <j:choose>
            <j:when test="${c.offlineCause!=null and !c.connecting}">
-              (<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}"/> ${%offline})
+              (<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="error image"/> ${%offline})


Suggested change

(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="error image"/> ${%offline})

(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="Agent offline"/> ${%offline})

MarkEWaite · 2024-05-21T20:25:48Z

core/src/main/resources/lib/layout/dropdowns/custom.jelly

@@ -31,7 +31,7 @@ THE SOFTWARE.

        <![CDATA[
            <dd:custom>
-              <img src="jenkins.svg" />
+              <img src="jenkins.svg" alt="null"/>


Suggested change

<img src="jenkins.svg" alt="null"/>

<img src="jenkins.svg" alt="Jenkins logo"/>

daniel-beck

This PR misunderstands the recommendation in Jira. null isn't intended as a literal value, but to represent the explicitly specified empty value (alt="").

daniel-beck · 2024-05-21T20:30:08Z

.github/config.yml

@@ -20,6 +20,6 @@ firstPRMergeComment: >

  <a href="https://www.jenkins.io/participate/" target="_blank">
   <picture>
-     <img width="600" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
+     <img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">


~~Needs to be localizable.~~

Suggested change

<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

<img width="600" alt="${%Jenkins welcome page}" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

Additionally I am not sure welcome page adequately describes what this is.

daniel-beck · 2024-05-21T20:31:36Z

core/src/main/resources/jenkins/model/Jenkins/oops.jelly

@@ -32,7 +32,7 @@ THE SOFTWARE.
    <l:header />
    <l:main-panel>
        <h1 style="text-align: center">
-          <img src="${imagesURL}/rage.svg" height="179" width="154"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
+          <img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>


Decorative only. Also, null isn't intended as a literal value, but to represent the explicitly specified empty value (alt="").

Suggested change

<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <st:nbsp/>${%Oops!}

<img src="${imagesURL}/rage.svg" height="179" width="154" alt=""/> <st:nbsp/>${%Oops!}

merge jenkins master branch to feature/add-null-text

…o feature/add-null-text-alt

merging to local branch

…Harwani/jenkins into feature/add-null-text-alt

…tors.jelly

JanhviHarwani · 2024-05-24T02:02:39Z

I have resolved all the comments in the PR. Thank you for taking out time to look at the PR.

daniel-beck · 2024-05-24T09:52:31Z

.github/config.yml

@@ -20,6 +20,6 @@ firstPRMergeComment: >

  <a href="https://www.jenkins.io/participate/" target="_blank">
   <picture>
-     <img width="600" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
+     <img width="600" alt=${%Jenkins welcome page} src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">


This applied the wrong suggestion from the comment thread. Mark pointed out I was wrong. (Also would be syntactically invalid in Jelly.)

Suggested change

<img width="600" alt=${%Jenkins welcome page} src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

<img width="600" alt="Jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

(Also I'm not sure this particular alt text is good, but that's a separate problem. I encourage you to consider what the image represents on this page, and how that would be accomplished in alt text.)

daniel-beck · 2024-05-24T09:54:22Z

core/src/main/resources/hudson/diagnosis/MemoryUsageMonitor/index.jelly

@@ -61,7 +61,7 @@ THE SOFTWARE.
          </j:otherwise>
        </j:choose>
      </div>
-      <img src="graph?type=${type}&amp;width=500&amp;height=300" />
+      <img src="graph?type=${type}&amp;width=500&amp;height=300" alt="memory usage monitor graph" />


Suggested change

<img src="graph?type=${type}&width=500&height=300" alt="memory usage monitor graph" />

<img src="graph?type=${type}&width=500&height=300" alt="${%memory usage monitor graph}" />

The same applies to all .jelly files. (Previously mentioned in #9296 (comment))

daniel-beck · 2024-05-24T09:54:57Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

@@ -50,13 +50,13 @@ THE SOFTWARE.
            ${%No files in directory}
           <j:if test="${showSymlinkWarning}">
             <p>
-                <img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+                <img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink alert"/>


Since the text in the next line exists, there is no need for an alt text here. This icon exists only to make the notice stand out.

daniel-beck · 2024-05-24T09:55:01Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

               ${%Symlinks are hidden}
             </p>
            </j:if>
           <j:if test="${showTmpDirWarning}">
             <p>
-               <img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+               <img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="temporary directory warning"/>


Since the text in the next line exists, there is no need for an alt text here. This icon exists only to make the notice stand out.

daniel-beck · 2024-05-24T09:55:06Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

@@ -124,13 +124,13 @@ THE SOFTWARE.
           </table>
           <j:if test="${showSymlinkWarning}">
             <p>
-                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink warning"/>


Since the text in the next line exists, there is no need for an alt text here. This icon exists only to make the notice stand out.

daniel-beck · 2024-05-24T09:55:09Z

core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly

               ${%Symlinks are hidden}
             </p>
            </j:if>
           <j:if test="${showTmpDirWarning}">
             <p>
-                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" />
+                <img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="temporary directory warning"/>


Since the text in the next line exists, there is no need for an alt text here. This icon exists only to make the notice stand out.

daniel-beck · 2024-05-24T09:56:47Z

core/src/main/resources/jenkins/model/Jenkins/oops.jelly

@@ -32,7 +32,7 @@ THE SOFTWARE.
    <l:header />
    <l:main-panel>
        <h1 style="text-align: center">
-          <img src="${imagesURL}/rage.svg" height="179" width="154"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>
+          <img src="${imagesURL}/rage.svg" height="179" width="154" alt=""/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span>


Inconsistent with the change in _404_simple.jelly, why?

(Personally I like this one more for the same reason as I mentioned in a number of other comments.)

github-actions · 2024-06-18T06:35:23Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

JanhviHarwani and others added 2 commits May 21, 2024 12:12

Merge pull request #1 from jenkinsci/master

7c874c4

merging current changes

Added alt attribute to all img tag

08fc4b7

Added null as text in alt attribute

4a2c910

MarkEWaite requested changes May 21, 2024

View reviewed changes

daniel-beck requested changes May 21, 2024

View reviewed changes

JanhviHarwani and others added 6 commits May 23, 2024 18:28

Merge pull request #2 from jenkinsci/master

8cf6508

merge jenkins master branch to feature/add-null-text

Merge branch 'master' of https://github.com/JanhviHarwani/jenkins int…

6d4fa24

…o feature/add-null-text-alt

Merge pull request #3 from jenkinsci/master

c7867b2

merging to local branch

Resolved all the PR comments

4d8fd42

Merge branch 'feature/add-null-text-alt' of https://github.com/Janhvi…

9eafafe

…Harwani/jenkins into feature/add-null-text-alt

Updated alt image messages for dir.jelly, _404_simple.jelly and execu…

e16257d

…tors.jelly

daniel-beck reviewed May 24, 2024

View reviewed changes

github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 18, 2024

Merge branch 'master' into feature/add-null-text-alt

1b731b5

github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jun 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add null text alt #9296

Feature/add null text alt #9296

JanhviHarwani commented May 21, 2024 •

edited

Submitter checklist

Maintainer checklist

welcome bot commented May 21, 2024

MarkEWaite commented May 21, 2024

MarkEWaite left a comment

MarkEWaite May 21, 2024

daniel-beck May 21, 2024 •

edited

MarkEWaite May 21, 2024

daniel-beck May 22, 2024 •

edited

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

daniel-beck May 21, 2024

MarkEWaite May 21, 2024

MarkEWaite May 21, 2024

daniel-beck left a comment

daniel-beck May 21, 2024 •

edited

daniel-beck May 21, 2024

JanhviHarwani commented May 24, 2024

daniel-beck May 24, 2024 •

edited

daniel-beck May 24, 2024

daniel-beck May 24, 2024

daniel-beck May 24, 2024

daniel-beck May 24, 2024

daniel-beck May 24, 2024

daniel-beck May 24, 2024

daniel-beck May 24, 2024

github-actions bot commented Jun 18, 2024

	<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
	<img width="600" alt="Jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

	<img width="600" alt="jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
	<img width="600" alt="${%Jenkins welcome page}" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

	<img src="graph?type=${type}&width=500&height=300" alt="null" />
	<img src="graph?type=${type}&width=500&height=300" alt="memory usage monitor graph" />

	<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>
	<img id="symlinkalert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink alert"/>

	<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="null"/>
	<img id="tmpdiralert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="temporary directory warning"/>

	<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="warning image"/>
	<img id="alert" src="${imagesURL}/svgs/warning.svg" width="16" height="16" alt="symlink warning"/>

	<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/>
	<img src="${imagesURL}/rage.svg" height="179" width="154" alt="Page not found"/>

	(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="error image"/> ${%offline})
	(<img src="${imagesURL}/svgs/error.svg" width="16" height="16" title="${c.offlineCause}" alt="Agent offline"/> ${%offline})

	<img src="jenkins.svg" alt="null"/>
	<img src="jenkins.svg" alt="Jenkins logo"/>

	<img width="600" alt=${%Jenkins welcome page} src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">
	<img width="600" alt="Jenkins welcome page" src="https://raw.githubusercontent.com/jenkinsci/jenkins/master/.github/images/jenkins-welcome.svg">

Feature/add null text alt #9296

Are you sure you want to change the base?

Feature/add null text alt #9296

Conversation

JanhviHarwani commented May 21, 2024 • edited

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

welcome bot commented May 21, 2024

MarkEWaite commented May 21, 2024

MarkEWaite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-beck May 21, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-beck May 22, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-beck left a comment

Choose a reason for hiding this comment

daniel-beck May 21, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JanhviHarwani commented May 24, 2024

daniel-beck May 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 18, 2024

JanhviHarwani commented May 21, 2024 •

edited

daniel-beck May 21, 2024 •

edited

daniel-beck May 22, 2024 •

edited

daniel-beck May 21, 2024 •

edited

daniel-beck May 24, 2024 •

edited