Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added action.yaml and scripts to install latest #13

Merged
merged 1 commit into from
Feb 21, 2022
Merged

added action.yaml and scripts to install latest #13

merged 1 commit into from
Feb 21, 2022

Conversation

garethahealy
Copy link
Contributor

adds:

  • github action to test the prepackaged on PR
  • github action to build/release to ghrc.io both lazy and prepackaged
  • upgrades the prepackaged to latest LTS as base image is out of date (happy to move this out if the base can be upgraded/released - I had tons of issues using the base jenkins due to plugin versions etc)
  • adds action.yaml so can provide input

jonico
jonico approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@jonico jonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@jonico
Copy link
Collaborator

jonico commented Feb 21, 2022

Looks good to me, but would ❤️ a second pair of 👀 from @oleg-nenashev before merging

@oleg-nenashev oleg-nenashev added chore Maintenance enhancement New feature or request labels Feb 21, 2022
oleg-nenashev
oleg-nenashev approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely improvement compared to the previous state, +1 for merging

Later I suggest replacing the Docker image and plugin sets by the Vanilla Image of JFR

oleg-nenashev
oleg-nenashev reviewed Feb 21, 2022
View reviewed changes
jenkinsfile-runner-prepackaged/Dockerfile.build
Comment on lines +15 to +19
COPY base-plugins.txt /app/setup/plugins.txt

# NOTE: The base as of Feb '22, is 7 months old. For this reason, we need to download the latest LTS and upgrade the base bits
RUN curl -L http://updates.jenkins.io/download/war/${JENKINS_VERSION}/jenkins.war -o /app/jenkins-${JENKINS_VERSION}.war
RUN apt-get update && apt-get install -y zip git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad Too many emergencies in personal life, co-maintainers are always welcome

jenkinsfile-runner-prepackaged/Dockerfile.build
@@ -0,0 +1,25 @@
FROM jenkins/jenkinsfile-runner:adoptopenjdk-11-hotspot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR https://github.com/jenkinsci/jenkinsfile-runner/pkgs/container/jenkinsfile-runner can be used for the latest version of Jenkinsfile Runner

@oleg-nenashev oleg-nenashev merged commit bcaea15 into jenkinsci:master Feb 21, 2022
@oleg-nenashev
Copy link
Member

FTR I started #14 @garethahealy @jonico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

@jonico jonico jonico approved these changes

Assignees
No one assigned
Labels
chore Maintenance enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garethahealy @jonico @oleg-nenashev