Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the Plugin Installation Manager Tool into the Vanilla base image #198

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Include the Plugin Installation Manager Tool into the Vanilla base image #198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86cb599
add jenkins-plugin-manager
mostafahussein Oct 13, 2019
eafe83d
update Dockerfile and docs
mostafahussein Nov 4, 2019
4160ee4
Merge branch 'master' into extend-runner
oleg-nenashev Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ RUN mkdir /app && unzip /jenkinsfile-runner/vanilla-package/target/war/jenkins.w

FROM openjdk:8-jdk
ENV JENKINS_UC https://updates.jenkins.io
ENV JENKINS_PM_VERSION 0.1-alpha-10
ENV JENKINS_PM_URL https://github.com/jenkinsci/plugin-installation-manager-tool/releases/download/plugin-management-parent-pom-$JENKINS_PM_VERSION/jenkins-plugin-manager-$JENKINS_PM_VERSION.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why it is located in POM instead of CLI. CC @stopalopa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that we should move these lines to be installed through the POM ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the ping. No, no action required here. It is rather about the GitHub releases deployment

USER root
RUN mkdir -p /app /usr/share/jenkins/ref/plugins
RUN mkdir -p /app/bin /usr/share/jenkins/ref/plugins && wget $JENKINS_PM_URL -O /app/bin/jenkins-plugin-manager.jar
COPY --from=jenkinsfilerunner-build /app/jenkins /app/jenkins
COPY --from=jenkinsfilerunner-build /jenkinsfile-runner/app/target/appassembler /app
COPY --from=jenkinsfilerunner-build /jenkinsfile-runner/vanilla-package/target/plugins /usr/share/jenkins/ref/plugins
Expand Down