Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent PluginServletFilter warnings when running JFR as a standalone JAR #294

Merged
merged 1 commit into from
May 10, 2020
Merged

Prevent PluginServletFilter warnings when running JFR as a standalone JAR #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
package io.jenkins.jenkinsfile.runner;

import hudson.ClassicPluginStrategy;
import hudson.util.PluginServletFilter;
import io.jenkins.jenkinsfile.runner.bootstrap.Bootstrap;
import io.jenkins.jenkinsfile.runner.util.HudsonHomeLoader;
import org.eclipse.jetty.security.AbstractLoginService;
import org.eclipse.jetty.security.HashLoginService;
import org.eclipse.jetty.security.LoginService;
import org.eclipse.jetty.server.Server;
import org.eclipse.jetty.util.thread.QueuedThreadPool;
import org.eclipse.jetty.webapp.Configuration;
import org.eclipse.jetty.webapp.WebAppContext;
import org.eclipse.jetty.webapp.WebXmlConfiguration;

import javax.servlet.DispatcherType;
import javax.servlet.ServletContext;
import java.util.HashSet;
import java.util.Set;
import java.util.EnumSet;
import java.util.logging.Level;
import java.util.logging.Logger;

Expand Down Expand Up @@ -54,6 +54,11 @@ protected ServletContext createWebServer() throws Exception {
context.getSecurityHandler().setLoginService(configureUserRealm());
context.setResourceBase(bootstrap.warDir.getPath());

// Jenkins core and some extension points supply extension points which try to access the filter
// In Jenkins core it is define in web.xml
// TODO: Consider reusing Jenkins web.xml instead of manual magic
context.addFilter(PluginServletFilter.class, "/*", EnumSet.of(DispatcherType.REQUEST));

server.start();

localPort = -1;
Expand Down