Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly export the minimum supported Jenkins version #339

Merged
merged 1 commit into from Jul 26, 2020

Conversation

PierreBtz
Copy link
Contributor

Fixes #257 .

What happened is that when generating the pom.properties, the Maven Archiver plugin is not exactly working as one might expect (see sources).
So we cannot really rely on the pom.properties, IMHO we don't need to export the whole properties of the pom, so simply using the resource plugin filtering a new property file should answer the need.

After the fix:

$ java -jar app/target/jenkinsfile-runner-standalone.jar -jv 2.204.5
Jenkins version [2.204.5] not suported by this jenkinsfile-runner version (requires 2.235.2).
java -jar app/target/jenkinsfile-runner-standalone.jar --version
1.0-beta-15-SNAPSHOT

@PierreBtz PierreBtz requested a review from a team as a code owner July 25, 2020 12:08
@oleg-nenashev oleg-nenashev added the bug Something isn't working label Jul 25, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I have to admit that I have not tested this scenario on real cases, because the version is managed differently there. The fix looks right

@oleg-nenashev oleg-nenashev merged commit 191f50a into jenkinsci:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-jv (--jenkins-verion) flag crashing CLI
2 participants