Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not specifying any plugin file #368

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

PierreBtz
Copy link
Contributor

It's currently not possible to run without specifying any plugin file.

@PierreBtz PierreBtz requested a review from a team as a code owner September 19, 2020 14:39
@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Sep 20, 2020
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC from #347 , not specifying plugins does not fully work at the moment. Bundled plugins are in classpath and largely work as extension points, but Jenkins.instance.oluginManager.getPlugin() returns null for such plugins. It does not block this pull request, but it would definitely benefit from some documentation until the metadata packaging issue is resolved

@PierreBtz
Copy link
Contributor Author

MMhh, I must admit I went with the simplest of pipeline (echo 'hello world') and I can confirm this not very realistic use case works. I'll try to play a bit more and drop a line in the doc.

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Sep 21, 2020

@PierreBtz Should not be a problem once the new Packaging flow is finalized. I plan to inject bundled plugin metadata so that the JFR plugin manager properly loads it even if there is no HPIs referenced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants