Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use adoc code listing instead of md style #386

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Use adoc code listing instead of md style #386

merged 1 commit into from
Oct 8, 2020

Conversation

rsvoboda
Copy link
Collaborator

@rsvoboda rsvoboda commented Oct 8, 2020

Use adoc code listing instead of md style

@rsvoboda rsvoboda requested a review from a team as a code owner October 8, 2020 20:10
@oleg-nenashev oleg-nenashev added the documentation Documentation updates label Oct 8, 2020
oleg-nenashev
oleg-nenashev approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's better to use the standard Asciidoc syntax. In practice, it should not be a problem. Modern rendering tools accept the most of GitHub Flavoured Markdown syntax in Asciidoc anyway, but linters might disagree.

@oleg-nenashev oleg-nenashev merged commit 071a5d2 into jenkinsci:master Oct 8, 2020
@oleg-nenashev
Copy link
Member

Thanks for your contribution @rsvoboda !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
documentation Documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsvoboda @oleg-nenashev