Create ClassLoaders inside doPrivileged() + Auto-close the WAR file after exploding it #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Oct 28, 2020
| @@ -338,12 +341,12 @@ public int run() throws Throwable { | |||
| } | |||
| } | |||
|
|
|||
| public ClassLoader createJenkinsWarClassLoader() throws IOException, NoSuchMethodException, InvocationTargetException, IllegalAccessException { | |||
There was a problem hiding this comment.
I do not recall what led to this exception list
| return new ClassLoaderBuilder(new SideClassLoader(getPlatformClassloader())) | ||
| .collectJars(new File(warDir,"WEB-INF/lib")) | ||
| public ClassLoader createJenkinsWarClassLoader() throws PrivilegedActionException { | ||
| return AccessController.doPrivileged((PrivilegedExceptionAction<ClassLoader>) () -> new ClassLoaderBuilder(new SideClassLoader(getPlatformClassloader())) |
There was a problem hiding this comment.
Jenkins is unlikely to work on advanced security policies . Should be fine though I will need to add Autotests for the resource loading
There was a problem hiding this comment.
This is pointless. See spotbugs/spotbugs#1515
oleg-nenashev
approved these changes
Nov 1, 2020
There was a problem hiding this comment.
I tested it locally to verify the workaround for #413, and I confirm it still works well after the patch
oleg-nenashev
changed the title
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #374