Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that plugin dependencies are aligned with JFR requirements + Remove the obsolete databound demo and test #430

Merged
merged 8 commits into from
Nov 24, 2020

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Nov 24, 2020

Contributes to #344 . After this patch, it will be possible to use custom versions in children packaging POMs.

@oleg-nenashev oleg-nenashev added the developer Features for those who extend Jenkinsfile Runner label Nov 24, 2020
@oleg-nenashev oleg-nenashev marked this pull request as ready for review November 24, 2020 13:03
@oleg-nenashev oleg-nenashev requested a review from a team as a code owner November 24, 2020 13:03
@oleg-nenashev oleg-nenashev changed the title Maven Parent POM: Allow using custom version numbers in child packaging POMs Maven packaging Parent POM: Allow using custom version numbers in child packaging POMs + Allow setting a Jenkinsfile Runner version via jfr.version + Ensure that plugin dependencies are aligned with JFR requirements Nov 24, 2020
@oleg-nenashev
Copy link
Member Author

So this is also "solves" #392 for Custom WAR Packager based flows

Copy link
Member

@abayer abayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@oleg-nenashev oleg-nenashev added the internal Internal change which does not impact users label Nov 24, 2020
Jenkinsfile Outdated Show resolved Hide resolved
@oleg-nenashev
Copy link
Member Author

I will merge it to get the boilerplate development going. As documented in jenkinsci/custom-war-packager#193 , it leads to a Custom WAR Packager flow incompatibility, at least for the development versions.

@oleg-nenashev oleg-nenashev merged commit 11f07af into jenkinsci:master Nov 24, 2020
@oleg-nenashev oleg-nenashev changed the title Maven packaging Parent POM: Allow using custom version numbers in child packaging POMs + Allow setting a Jenkinsfile Runner version via jfr.version + Ensure that plugin dependencies are aligned with JFR requirements Maven packaging Parent POM: Allow using custom version numbers in child packaging POMs + Allow setting a Jenkinsfile Runner version via jfr.version + Ensure that plugin dependencies are aligned with JFR requirements + remove the obsolete databound demo and test Nov 24, 2020
@oleg-nenashev oleg-nenashev changed the title Maven packaging Parent POM: Allow using custom version numbers in child packaging POMs + Allow setting a Jenkinsfile Runner version via jfr.version + Ensure that plugin dependencies are aligned with JFR requirements + remove the obsolete databound demo and test Ensure that plugin dependencies are aligned with JFR requirements + Remove the obsolete databound demo and test Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Features for those who extend Jenkinsfile Runner internal Internal change which does not impact users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants