Add support for user provided Jenkinsfile path #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Jan 26, 2021
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 馃檪 , thank you for making this awesome project!
I just wanted to add a small feature request for the docker container portion of this project.
I didn't necessarily want to directly mount the Jenkinsfile into the exact location
/workspace/Jenkinsfile, so I was curious if adding a check for theJENKINSFILE_PATHvariable could be added. That way if a user wants to specify a full path to the Jenkinsfile then they could simply pass it with a:-e JENKINSFILE_PATH='<path_to_jenkinsfile>'. This would give the flexibility of mounting a directory and then specifying the full path per that variable, while still maintaining the default nature of executing the already planned happy path a user has now.Please let me know if there is anything, and thank you again for this amazing project 馃榿