Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow exposing HTTP and Agent connection ports via --httpPort and --agentPort options #517

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Allow exposing HTTP and Agent connection ports via --httpPort and --agentPort options #517

merged 1 commit into from
Jun 9, 2021

Conversation

oleg-nenashev
Copy link
Member

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@oleg-nenashev oleg-nenashev requested a review from a team as a code owner June 7, 2021 14:53
@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Jun 7, 2021
agentgonzo
agentgonzo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@agentgonzo agentgonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert in the JFR code, but:

  • It looks good to my naive eyes
  • Some info logging would be handy, but not essential

@oleg-nenashev
Copy link
Member Author

I would postpone logging @agentgonzo. There is a big effort to make there across the board

@oleg-nenashev oleg-nenashev merged commit 6f7a1c6 into jenkinsci:master Jun 9, 2021
@oleg-nenashev oleg-nenashev deleted the httpEndpoint branch June 9, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agentgonzo agentgonzo agentgonzo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oleg-nenashev @agentgonzo