Update to Jenkins LTS version 2.375 #696

romanisb · 2023-06-09T12:07:54Z

This PR is trying to address the current issues were using/building a JFR image with a Jenkins version > 2.346.3 fails (e.g. #686 or #657).

The changes are addressing:

Jenkins refactoring from JEP-230
Couple of dependency updates
Refactoring of some deprecations

I have commented some dependencies were @oleg-nenashev has added a TODO to remove.
I'm not 100% sure, but they could be safely removed now.

Testing done

Test Image

romanisb/jenkinsfile-runner:jenkins-core-2.375.4

(Build from packaging/docker/unix/eclipse-temurin-11-jre/Dockerfile):

Test Pipeline

Jenkinsfile

node() {
    echo("${Jenkins.instance.getVersion()}")
}

Command

docker run --rm -v ${pwd}:/workspace romanisb/jenkinsfile-runner:jenkins-core-2.375.4 -ns

Output

...<jpi related warnings removed>
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/app/jenkins/WEB-INF/lib/groovy-all-2.4.21.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Started
Resume disabled by user, switching to high-performance, low-durability mode.
[Pipeline] Start of Pipeline
[Pipeline] node
Running on Jenkins in /build
[Pipeline] {
[Pipeline] echo
2.375.4
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS

Submitter checklist

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

These modules were removed and converted into plugins with JEP-230 https://github.com/jenkinsci/jep/tree/master/jep/230

Initial try to go to next LTS version. Jetty dependency might cause some issue. Vanilla package had to loose as severely outdated plugin (incl. a test).

oleg-nenashev

Everything looks good, thanks you! I would likely go straight to Jetty 11 but it is a separate topic

romanisb · 2023-06-27T06:27:39Z

Everything looks good, thanks you! I would likely go straight to Jetty 11 but it is a separate topic

Thanks for the approval. Before merging this change, let me remove a change which shouldn't end up in this PR and clean up the commented dependencies.

This reverts commit 58aefbf.

romanisb · 2023-06-30T12:11:15Z

Done from my side. If I find the time I'll try to look into updating Jetty to version 11, but rather in another PR.

romanisb · 2023-07-17T08:33:09Z

Everything looks good, thanks you! I would likely go straight to Jetty 11 but it is a separate topic
@oleg-nenashev

I've looked into updating to Jetty 11 and straight away the compilation will fail because auf the namespace change from javax.* to jakarta.*:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsLauncher.java:[20,20] error: package javax.servlet does not exist
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsLauncher.java:[21,20] error: package javax.servlet does not exist
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsEmbedder.java:[77,20] error: package javax.servlet does not exist
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsLauncher.java:[80,14] error: cannot find symbol
  symbol:   class ServletContext
  location: class JenkinsLauncher<T>
  where T is a type-variable:
    T extends JenkinsLauncherCommand declared in class JenkinsLauncher
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/JenkinsEmbedder.java:[375,23] error: cannot find symbol
  symbol:   class ServletContext
  location: class JenkinsEmbedder
[ERROR] /mnt/c/Users/dev/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/PluginManagerImpl.java:[14,29] error: cannot find symbol
  symbol:   class ServletContext
  location: class PluginManagerImpl
[ERROR] /mnt/c/Users/dev/com/romanisb/jenkinsfile-runner/setup/src/main/java/io/jenkins/jenkinsfile/runner/NoListenerConfiguration.java:[8,20] error: package javax.servlet does not exist
[INFO] 7 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jenkinsfile Runner 1.0-beta-32-SNAPSHOT:
[INFO]
[INFO] Jenkinsfile Runner ................................. SUCCESS [  1.422 s]
[INFO] bootstrap .......................................... SUCCESS [  7.175 s]
[INFO] setup .............................................. FAILURE [  7.503 s]
[INFO] Jenkinsfile Runner: Plugin dependencies ............ SKIPPED
[INFO] payload ............................................ SKIPPED
[INFO] jenkinsfile-runner ................................. SKIPPED
[INFO] packaging-parent-pom-resources ..................... SKIPPED
[INFO] packaging-parent-pom ............................... SKIPPED
[INFO] packaging-parent-pom-slim .......................... SKIPPED
[INFO] vanilla-package .................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  30.009 s
[INFO] Finished at: 2023-07-17T10:26:19+02:00
[INFO] ------------------------------------------------------------------------

Also I'm not sure if Jetty 11 will somehow work with Jenkins core in the future, but I do not have that much in-depth knowledge in this:
https://www.jenkins.io/doc/administration/requirements/servlet-containers/

Tested with romanisb/jenkinsfile-runner@update-jenkins-core-2.375...romanisb:jenkinsfile-runner:jenkins-core-2.387-jetty-11

oleg-nenashev · 2023-07-17T17:46:57Z

Sorry for the response delays, is definitely something to look into

oleg-nenashev · 2023-07-17T17:47:34Z

I hope to catch up with the discussions here but it realistically won't happen until August

romanisb · 2023-07-20T12:27:12Z

I hope to catch up with the discussions here but it realistically won't happen until August

Yeah. No worries. Since this discussion is a bit off-topic with this PR, I've created a Github issue (#699), where the discussion could be continued.

lhupfeldt · 2023-09-18T11:53:55Z

Hi @oleg-nenashev, will there be a new (beta) release soon? I'm hoping for a fix for #686

lhupfeldt · 2023-10-05T08:50:03Z

Hi @oleg-nenashev, sorry to ask again, but will there be a new (beta) release soon? We have been unable to execute our pipeline tests for while.

oleg-nenashev · 2023-11-12T19:05:55Z

Sorry, catching up on the technical debt

lhupfeldt · 2023-11-13T11:40:24Z

Hi @oleg-nenashev is the fix in beta-32?

oleg-nenashev · 2023-11-13T21:10:49Z

@lhupfeldt yes

romanisb added 11 commits April 24, 2023 16:17

Remove Jenkins modules in setup pom.xml

de3c6dd

These modules were removed and converted into plugins with JEP-230 https://github.com/jenkinsci/jep/tree/master/jep/230

Adapt to new location of winstone.jar

fad0ead

Update to Jenkins core version 2.361.4

f77ab6c

Initial try to go to next LTS version. Jetty dependency might cause some issue. Vanilla package had to loose as severely outdated plugin (incl. a test).

Update to Jenkins core 2.375.4 and jetty 10.0.12

692705d

Fix JFRLoginService in JenkinsLauncher

420e625

Resolve deprecation of Class.newInstance() usage

3ca6f6c

Provide emptyList instead of null in EventListeners config

a0b70c0

Increase retry count in writeLogTo

58aefbf

Remove duplicated and managed dep. versions

1e77c9d

Replace deprecated readFileToString() function

50d344a

Replace deprecated ACL impersonate function

9ab3463

romanisb requested a review from a team as a code owner June 9, 2023 12:07

oleg-nenashev approved these changes Jun 26, 2023

View reviewed changes

romanisb added 2 commits June 28, 2023 13:56

Revert "Increase retry count in writeLogTo"

d7342a0

This reverts commit 58aefbf.

Remove obsolete dependencies

9f1ac4d

romanisb mentioned this pull request Jul 20, 2023

[Discussion] Update to Jetty version 11 #699

Open

oleg-nenashev added the dependencies Pull requests that update a dependency file label Aug 6, 2023

oleg-nenashev merged commit f6f1061 into jenkinsci:main Aug 6, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Jenkins LTS version 2.375 #696

Update to Jenkins LTS version 2.375 #696

romanisb commented Jun 9, 2023 •

edited

Loading

oleg-nenashev left a comment

romanisb commented Jun 27, 2023 •

edited

Loading

romanisb commented Jun 30, 2023

romanisb commented Jul 17, 2023 •

edited

Loading

oleg-nenashev commented Jul 17, 2023

oleg-nenashev commented Jul 17, 2023

romanisb commented Jul 20, 2023

lhupfeldt commented Sep 18, 2023

lhupfeldt commented Oct 5, 2023

oleg-nenashev commented Nov 12, 2023

lhupfeldt commented Nov 13, 2023

oleg-nenashev commented Nov 13, 2023

Update to Jenkins LTS version 2.375 #696

Update to Jenkins LTS version 2.375 #696

Conversation

romanisb commented Jun 9, 2023 • edited Loading

Testing done

Test Image

Test Pipeline

Jenkinsfile

Command

Output

Submitter checklist

oleg-nenashev left a comment

Choose a reason for hiding this comment

romanisb commented Jun 27, 2023 • edited Loading

romanisb commented Jun 30, 2023

romanisb commented Jul 17, 2023 • edited Loading

oleg-nenashev commented Jul 17, 2023

oleg-nenashev commented Jul 17, 2023

romanisb commented Jul 20, 2023

lhupfeldt commented Sep 18, 2023

lhupfeldt commented Oct 5, 2023

oleg-nenashev commented Nov 12, 2023

lhupfeldt commented Nov 13, 2023

oleg-nenashev commented Nov 13, 2023

romanisb commented Jun 9, 2023 •

edited

Loading

romanisb commented Jun 27, 2023 •

edited

Loading

romanisb commented Jul 17, 2023 •

edited

Loading