New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jenkins Operator Draft #238
Conversation
I'll take a look at this shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the slave/agent terminology, LGTM
jep/0000/README.adoc
Outdated
|
||
==== Make backup of Jenkins jobs history | ||
|
||
Backup Jenkins jobs history using tools provided by Kubernetes itself and optionally a cloud provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are talking about build history here: $JENKINS_HOME/jobs/**/builds/
.
Job history would track changes to $JENKINS_HOME/jobs/**/config.xml
, something done in traditional Jenkins installations using the jobConfigHistory
or scm-sync-configuration
plugins, which ought to be superseded by a proper operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick Jenkins Operator have to care about build history
. Job history will be tracked in git repository because all jobs will be provided by Job DSL plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick please look at new commit
jep/0000/README.adoc
Outdated
== Motivation | ||
|
||
Jenkins Operator contains complex knowledge about operating Jenkins, in particular running it on Kubernetes. | ||
Given that it shouldn't be a part Jenkins implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this paragraph is saying. Perhaps reword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick please look at new commit
jep/0000/README.adoc
Outdated
This document does not propose a specific design or implementation, as other JEPs might. This is intentional. | ||
This document specifies the concept of "Jenkins Operator" and the mission and priorities of the project. | ||
Later related JEPs will address design and implementation. Limiting the scope of this JEP to high-level goals will let | ||
us build a solid consensus for that direction separate from the design of individual features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitwiseman what was the outcome of our discussion of “meta-JEPs”? I thought we had agreed to discourage them and instead use SIGs for that purpose, limiting actual JEPs to concrete proposals. But not sure if these guidelines were ever solidified and written down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick please look at new commit
jep/0000/README.adoc
Outdated
== Backwards Compatibility | ||
|
||
Jenkins Operator is intended to run as an separate program and not require dedicated extension integrated in | ||
jenkins-core nor specific API implemented by plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except potentially via the configuration-as-code
plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick You are right. I think there will be more plugins required by Jenkins Operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick please look at new commit
- updated Motivation, Reasoning and Backwards Compatibility sections
I think https://github.com/jenkinsci/jep/tree/master/jep/0000 should be removed and there are two entries in https://github.com/jenkinsci/jep/blob/master/jep/README.adoc. |
@tomaszsek Thanks for catching that. |
Submitted for approval as draft JEP by @jenkinsci/jep-editors.