Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkins Operator Draft #238

Merged
merged 3 commits into from Feb 9, 2019
Merged

Add Jenkins Operator Draft #238

merged 3 commits into from Feb 9, 2019

Conversation

tomaszsek
Copy link
Contributor

Submitted for approval as draft JEP by @jenkinsci/jep-editors.

@bitwiseman
Copy link
Contributor

I'll take a look at this shortly.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the slave/agent terminology, LGTM

jep/0000/README.adoc Outdated Show resolved Hide resolved
jep/0000/README.adoc Outdated Show resolved Hide resolved

==== Make backup of Jenkins jobs history

Backup Jenkins jobs history using tools provided by Kubernetes itself and optionally a cloud provider.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are talking about build history here: $JENKINS_HOME/jobs/**/builds/.

Job history would track changes to $JENKINS_HOME/jobs/**/config.xml, something done in traditional Jenkins installations using the jobConfigHistory or scm-sync-configuration plugins, which ought to be superseded by a proper operator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick Jenkins Operator have to care about build history. Job history will be tracked in git repository because all jobs will be provided by Job DSL plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick please look at new commit

== Motivation

Jenkins Operator contains complex knowledge about operating Jenkins, in particular running it on Kubernetes.
Given that it shouldn't be a part Jenkins implementation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this paragraph is saying. Perhaps reword?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick please look at new commit

This document does not propose a specific design or implementation, as other JEPs might. This is intentional.
This document specifies the concept of "Jenkins Operator" and the mission and priorities of the project.
Later related JEPs will address design and implementation. Limiting the scope of this JEP to high-level goals will let
us build a solid consensus for that direction separate from the design of individual features.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitwiseman what was the outcome of our discussion of “meta-JEPs”? I thought we had agreed to discourage them and instead use SIGs for that purpose, limiting actual JEPs to concrete proposals. But not sure if these guidelines were ever solidified and written down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick please look at new commit

== Backwards Compatibility

Jenkins Operator is intended to run as an separate program and not require dedicated extension integrated in
jenkins-core nor specific API implemented by plugins.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except potentially via the configuration-as-code plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick You are right. I think there will be more plugins required by Jenkins Operator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jglick please look at new commit

jep/0000/README.adoc Show resolved Hide resolved
tomaszsek and others added 2 commits February 8, 2019 16:50
- updated Motivation, Reasoning and Backwards Compatibility sections
@bitwiseman bitwiseman merged commit ee71190 into jenkinsci:master Feb 9, 2019
@tomaszsek
Copy link
Contributor Author

tomaszsek commented Feb 10, 2019

@bitwiseman
Copy link
Contributor

@tomaszsek Thanks for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants