Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting that the merge to master occur when a JEP is finalized #25

Closed
wants to merge 1 commit into from

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 1, 2017

#12 apparently never said if or when a jep-nnnn feature branch would be merged into master. I am picking finalization time as a first pass, though it might make more sense to put it in master as soon as it is accepted.

(Frankly I was a little surprising to find that the merge to master does not happen as soon as the draft is accepted. That is after all the point at which you are committed to a particular number, so as a record of this JEP’s existence and status IMO it should be there already, even if it was ultimately rejected or abandoned.)

@bitwiseman
Copy link
Contributor

@jglick
You are correct about wanting JEPs to be recorded even if rejected. But I also think we don't want to merge to master while in draft, since as you've seen, they may got through a lot of changes. Having all that iterating off to the side seems better to me.

Maybe take a few minutes and propose what you think it really should look like and then other can counter-propose/amend?

@jglick
Copy link
Member Author

jglick commented Nov 6, 2017

I also think we don't want to merge to master while in draft, since as you've seen, they may got through a lot of changes.

And…so? Is there some problem with having lots of PRs filed against the master branch? Who cares?

@jglick jglick mentioned this pull request Nov 6, 2017
@jglick
Copy link
Member Author

jglick commented Nov 6, 2017

propose what you think it really should look like

#29

@bitwiseman
Copy link
Contributor

@jglick Closing this in favor of #29.

@bitwiseman bitwiseman closed this Nov 7, 2017
@jglick jglick deleted the final-merge branch November 9, 2017 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants