Simplify code #118
Merged
Simplify code #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`JobConfigHistoryBaseAction` already contains a `Jenkins` instance.
If `nodes` is anyway set on first call of `onConfigurationChange` it is not required to set it in the constructor. This simplifies the code.
Beeing able to overwrite this was used for testing purposes only. This complicated code a bit and was not used very often. The only use case at the moment is to test authorization for some methods. This can also be achieved by overwriting `getAccessControlledObject()` which was already done in other tests.
|
We're planning to do a release of JobConfigHistory soon. I prefer to merge this PR after the next release. |
|
That's ok for me. I am already working on another pull request. |
|
Hello, I think I introduced the indirection because testing gets easier with this |
|
@mfriedenhagen Have you seen my commit message on b3e06d2 regarding the removal of the How do we go on with this pull request? Are there objections to not merge it as is? |
|
@darxriggs, I would always prefer to inject such a dependency but as I am not actively involved in the development anymore, I think @Jochen-A-Fuerbacher should decide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all about simplifying code around getting an instance of
Jenkins.More details can be found in the commit comments.