fix: Make preformatted html less blocky #302

rahulsom · 2023-07-12T20:30:26Z

A UI refresh to Jenkins made the <pre> look blocky. While that works for most of the other parts of Jenkins, it does not suit what this plugin does.

This change makes it go back to the more traditional look of this plugin.

Before

After

Testing done

All existing tests pass when running mvn verify

Submitter checklist

Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

A UI refresh to Jenkins made the `<pre>` look blocky. While that works for most of the other parts of Jenkins, it does not suit what this plugin does. This change makes it go back to the more traditional look of this plugin.

rahulsom · 2023-07-12T20:37:13Z

src/main/webapp/css/style.css

@@ -648,3 +648,8 @@ table.no-borders-warning caption {
 .jch-entries-per-page .jenkins-button, .jch-pagination .jenkins-button {
    min-width: 52px;
 }
+
+.jch pre {
+  background-color: var(--white);


I thought of using --background but there is a lot more work to be done to make this work with the Dark theme.

fix: Make preformatted html less blocky

6addab5

A UI refresh to Jenkins made the `<pre>` look blocky. While that works for most of the other parts of Jenkins, it does not suit what this plugin does. This change makes it go back to the more traditional look of this plugin.

rahulsom requested a review from a team as a code owner July 12, 2023 20:30

rahulsom commented Jul 12, 2023

View reviewed changes

NotMyFault approved these changes Jul 14, 2023

View reviewed changes

NotMyFault added the enhancement label Jul 14, 2023

NotMyFault merged commit bd38b12 into jenkinsci:master Jul 14, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Make preformatted html less blocky #302

fix: Make preformatted html less blocky #302

rahulsom commented Jul 12, 2023

Submitter checklist

rahulsom Jul 12, 2023

fix: Make preformatted html less blocky #302

fix: Make preformatted html less blocky #302

Conversation

rahulsom commented Jul 12, 2023

Testing done

Submitter checklist

rahulsom Jul 12, 2023

Choose a reason for hiding this comment