Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64639] Removed the table tag inside the entity for new Jenkins versions #16

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

ironcerocloudbees
Copy link
Contributor

[JENKINS-64639]

I checked the master version running from a Jenkins 2.279 and I found some UI design errors using div instead of tables. So, I removed all table tag matches for new Jenkins versions where we have the variable divBasedFormLayout.

Once those table tags were removed the UI of the plugin worked fine in Jenkins 2.279 and in Jenkins 2.263.4 as well.

@ironcerocloudbees
Copy link
Contributor Author

cc @timja, @fqueiruga, @dariver

@wolfs wolfs merged commit 0a15aec into jenkinsci:master Mar 10, 2021
@wolfs
Copy link
Member

wolfs commented Jun 30, 2021

@roebi I didn't do anything on this plugin for very long time now and I also don't use it anymore. Maybe my credentials work for releasing it, though I would prefer not to. Would you be willing to adopt this plugin and do a release?

@roebi
Copy link

roebi commented Jun 30, 2021

@wolfs Thanks for the timely feedback. I lack a lot of knowledge for the adoption of this plugin, such as implementation details, testing process, releasing.
As an alternative, we could generally switch to pipeline jobs - which would mean a lot of work for us.
Is there an alternative plugin?

Finally: table 2 div affects so many other plugins: is there a way that Jenkins can accept table and div?
See https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=20741

@timja
Copy link
Member

timja commented Jun 30, 2021

Finally: table 2 div affects so many other plugins: is there a way that Jenkins can accept table and div?

all the plugins that are maintained or have many users are fixed, the remaining are all un-maintained or few users I would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants