Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Fix poms, modernize #25

Closed
wants to merge 3 commits into from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Jan 25, 2023

Motivation

The plugins in this repository stand out as being by far the least actively maintained among the top 100 plugins by popularity.

They're by far the least recently released (March 2016) and have by far the oldest core dependency (1.580.1). Since ace-editor is a dependency of workflow-cps, there's no modern Pipeline-based Jenkins possible without it, making removal of unused implied dependencies cumbersome to impossible.

PR Content

This fixes the pom references broken since 2048280, and updates to the newest plugin parent POM.

As a result, this now depends on Jenkins 2.361 and requires Java 11 to build.

Also documented the core.symlinks requirement for Git.

Testing

Did some minimal testing of ace-editor via workflow-cps. While the generated JS output is slightly different (probably from an earlier, unreleased change), basic features (error annotation, collapsing blocks, syntax highlighting) worked.
Screenshot

Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally

Copy link

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, many times yes. Modernizing ace-editor will avoid future pain if jdk-tool or one of the older split plugins is deprecated. The deprecation of windows-slaves highlighted the type of problems that users can see due to implied dependencies.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkinsci/workflow-cps-plugin#653 is likely more maintainable.

@daniel-beck
Copy link
Member Author

@basil This is great, thank you.

@daniel-beck daniel-beck closed this Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants