Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pull the skippedMessage from the skipped xml element text when there is no message attribute available. #114

Merged
merged 5 commits into from Nov 21, 2018

Conversation

gyuvaraj10
Copy link
Contributor

Example Data:

<?xml version="1.0" encoding="UTF-8"?><testsuite failures="0" name="cucumber.runtime.formatter.JUnitFormatter" skipped="1" tests="1" time="0.172697">
<testcase classname="Test Sample" name="Test Example" time="0.172697">
<skipped><![CDATA[Given skip This Test........................................................pending
]]></skipped>
</testcase>
</testsuite>

Yuvaraj and others added 4 commits October 30, 2018 14:31
@gyuvaraj10
Copy link
Contributor Author

Hi @jtnord ,
Could you review this MR and merge if you are happy with this change?
Thank You,
Yuvaraj G

Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, although I really wish junit or someone did actually define a schema rather than having lots of interpretations of some source that existed at some point in time.

@jglick

src/test/java/hudson/tasks/junit/TestResultTest.java Outdated Show resolved Hide resolved
@jtnord
Copy link
Member

jtnord commented Nov 6, 2018

Btw you know you get much better cucumber support parsing the JSON than getting it to output XML? https://plugins.jenkins.io/cucumber-testresult-plugin

1 similar comment
@jtnord
Copy link
Member

jtnord commented Nov 6, 2018

Btw you know you get much better cucumber support parsing the JSON than getting it to output XML? https://plugins.jenkins.io/cucumber-testresult-plugin

@gyuvaraj10
Copy link
Contributor Author

Yes, I know JSON paring is simpler than XML, but I do not know that the plugin exists. Thank you for sharing the info, I will go through the plugin.

@jtnord
Copy link
Member

jtnord commented Nov 12, 2018

@abayer, @jglick PTAL. (@gyuvaraj10 I am not a maintainer of the junit plugin)

@jglick
Copy link
Member

jglick commented Nov 14, 2018

I am not a maintainer either.

@olivergondza olivergondza merged commit bdf558b into jenkinsci:master Nov 21, 2018
@olivergondza
Copy link
Member

Thanks!

@gyuvaraj10
Copy link
Contributor Author

Thank you @olivergondza for merging this change. Please let me know when this change will be released to maven central.

@gyuvaraj10
Copy link
Contributor Author

Hi @daniel-beck, Can you confirm when the next version of this plugin will be released?

@olivergondza
Copy link
Member

1.27 released. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants