Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish only results included in current invocation to checks api - fixes #198 #199

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Oct 29, 2020

This, I believe, should fix the problem described in #198. However, I'm at a bit of a loss as to how best to test it, short of mocking a checks publisher and inspecting calls to that.

fixes #198

@timja
Copy link
Member

timja commented Oct 29, 2020

This, I believe, should fix the problem described in #198. However, I'm at a bit of a loss as to how best to test it, short of mocking a checks publisher and inspecting calls to that.

I think just manually testing this bit is fine. otherwise yeah verifying the second call only contains the second results and not the combination of both would be the first to go.

@mrginglymus mrginglymus marked this pull request as ready for review November 10, 2020 14:57
@mrginglymus
Copy link
Contributor Author

@timja apologies for the delay here. I've finally had a chance to test this on our jenkins and it does the job 👍

@timja timja merged commit 13de22e into jenkinsci:master Nov 10, 2020
@mrginglymus mrginglymus deleted the one-invocation-per-check branch November 10, 2020 15:06
@mrginglymus
Copy link
Contributor Author

Thanks for merging this @timja; do you have a rough idea of when you might next cut a release?

@timja
Copy link
Member

timja commented Nov 16, 2020

Thanks for merging this @timja; do you have a rough idea of when you might next cut a release?

thanks for the nudge, I've triggered it. Should be available in ~15 mins or so

@mrginglymus
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch between test summary and tests reported
2 participants