New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-26276] Implemented JUnitStep ("archiveTestResults") #9
Conversation
Can be used as follows: def tests = archiveTestResults() if(tests.failCount > 0) { // take action! }
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
The problem with doing this in |
@DataBoundSetter | ||
public void setLocation(@Nullable String location) { | ||
this.location = location; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this. If location
is defined in a @DataBoundConstructor
, it should be final
and there should be no @DataBoundSetter
.
Thanks for the feedback! Will try to submit fixes by the end of next week. |
- Renamed JUnitStep.location to JUnitStep.testResults to be consistent with JUnitResultArchiver - @Whitelisted getters on TestResultSummary - Added config.jelly for JUnitStep - Removed updates to build status - caller can set build to error or unstable if desired.
Any plans to continue work on this? |
+1 on this feature |
@jglick Are you fine with the current impl? If yes, I'll try to integrate it |
How about make it an optional dependency? I would vote for that even if junit were not bundled... |
Also, the feature is untested. |
+1 for resurrecting this - it'd be a handy feature. |
Any update on this PR? No go? |
Closing - I added a |
Here is a first attempt at a workflow step that returns test summary results to the caller.
Can be used as follows:
Feedback welcome!