Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-43995] Set FlowNode status when unstable. #96

Closed
wants to merge 2 commits into from
Closed

[JENKINS-43995] Set FlowNode status when unstable. #96

wants to merge 2 commits into from

Conversation

abayer
Copy link
Member

@abayer abayer commented Dec 7, 2017

JENKINS-43995

Downstream of jenkinsci/workflow-cps-plugin#192 and jenkinsci/workflow-api-plugin#63

Also tweaked tests to always check against fail count (and verify block status).

@abayer abayer requested a review from svanoort December 7, 2017 21:00
svanoort
svanoort approved these changes Dec 8, 2017
View reviewed changes
Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me... the upstreams just need to get there for this to be settled.

@jglick
Copy link
Member

jglick commented Aug 20, 2018

@abayer what is the status of this?

@dwnusbaum dwnusbaum mentioned this pull request Apr 19, 2019
Merged
@timja
Copy link
Member

timja commented Jul 30, 2020

@abayer what is the status of this?

Going to assume abandoned.

@timja timja closed this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanoort svanoort svanoort approved these changes

Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abayer @jglick @timja @svanoort